Currently to make profiles accessible from Inspector and Console hand-written wrappers are used (WebCore/inspector/JavaScriptProfile*). I think it makes more sense to use generated bindings instead.
Created attachment 48569 [details] Proposed patch
Created attachment 48636 [details] updated patch with a small fix
Created attachment 48644 [details] instead of replacing, just move those wrappers
Attachment 48644 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebCore/inspector/JavaScriptProfileNode.h': Can't open for reading WebCore/bindings/js/JavaScriptProfileNode.h:32: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptProfileNode.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/bindings/js/JavaScriptProfile.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Skipping input 'WebCore/inspector/JavaScriptProfileNode.cpp': Can't open for reading Skipping input 'WebCore/inspector/JavaScriptProfile.h': Can't open for reading Skipping input 'WebCore/inspector/JavaScriptProfile.cpp': Can't open for reading WebCore/bindings/js/JavaScriptProfile.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebCore/bindings/js/JavaScriptProfileNode.cpp:33: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/JavaScriptProfileNode.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 48644 [details] instead of replacing, just move those wrappers I think you should merge JavaScriptProfile into ScriptProfile. JavaScriptNode also should be simply ScriptNode, both encapsulating JSC specifics. There is no more need in typedefs.
Created attachment 48745 [details] fixed style issues in the last patch
Comment on attachment 48745 [details] fixed style issues in the last patch Please make sure you land it as svn move.
Created attachment 48808 [details] committed revision -- no changes to JSBindingsAllInOne.cpp
Manually committed r54820: http://trac.webkit.org/changeset/54820