Bug 34840 - [Android] cmath using declarations in MathExtras.h cause build errors on Android
Summary: [Android] cmath using declarations in MathExtras.h cause build errors on Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 07:26 PST by Steve Block
Modified: 2010-02-11 08:04 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2010-02-11 07:32 PST, Steve Block
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-11 07:26:46 PST
cmath using declarations in MathExtras.h cause build errors on Android
Android does not provide these math functions

This was introduced in http://trac.webkit.org/changeset/54388
Comment 1 Steve Block 2010-02-11 07:32:26 PST
Created attachment 48561 [details]
Patch
Comment 2 Darin Adler 2010-02-11 07:51:08 PST
Comment on attachment 48561 [details]
Patch

I don't see why you are specifying COMPILER(GCC) there, but it seems OK.
Comment 3 Steve Block 2010-02-11 08:04:35 PST
Landed manually without GCC guard as http://trac.webkit.org/changeset/54655

Closing bug as resolved fixed