Bug 34836 - [Android] V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h
Summary: [Android] V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 04:32 PST by Steve Block
Modified: 2010-02-11 10:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2010-02-11 04:36 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2010-02-11 09:17 PST, Steve Block
dglazkov: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-11 04:32:02 PST
V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h
This is so that these files can use toV8() with type Node* in V8Collection.h

This was introduced in http://trac.webkit.org/changeset/54150

It seems that for Chromium, this include is picked up through an include chain which is guarded by a feature enable guard not used on Android.
Comment 1 Steve Block 2010-02-11 04:36:15 PST
Created attachment 48557 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-02-11 08:40:33 PST
Comment on attachment 48557 [details]
Patch

Per IM discussion, the right approach here is to make sure V8Node is correctly included whenever setCollectionIndexedGetter template is used, because it in turn uses toV8.
Comment 3 Steve Block 2010-02-11 09:17:13 PST
Created attachment 48570 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2010-02-11 10:21:05 PST
Comment on attachment 48570 [details]
Patch

sounds good.
Comment 5 Steve Block 2010-02-11 10:26:39 PST
Comment on attachment 48570 [details]
Patch

Will land manually as build is currently red
Comment 6 Steve Block 2010-02-11 10:28:35 PST
Landed manually as http://trac.webkit.org/changeset/54658

Closing bug as resolved fixed