Bug 34834 - check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
Summary: check-webkit-style should not complain about NULL sentinel in calls to g_strc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 01:28 PST by Martin Robinson
Modified: 2010-02-15 22:17 PST (History)
0 users

See Also:


Attachments
Patch for this issue (3.16 KB, patch)
2010-02-13 13:21 PST, Martin Robinson
darin: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-02-11 01:28:53 PST
Using 0 in place of NULL for these functions generates a compiler warning. check-webkit-style should make a similar check to the one done for g_object_get and g_object_set.
Comment 1 Martin Robinson 2010-02-13 13:21:26 PST
Created attachment 48711 [details]
Patch for this issue

I've attached a patch for this issue.
Comment 2 Martin Robinson 2010-02-15 22:17:53 PST
Committed r54808: <http://trac.webkit.org/changeset/54808>