Bug 34833 – Chromium DevTools: Trying to generate heap snapshots fast will generate more than expected

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

What steps will reproduce the problem?
1. Open a webpage say http://www.google.com
2. Open Inspector(Ctrl+Shift+I)
3. Go to Profiles tab
4. Hit 'Take a snapshot button' fast, say 5 times

What is the expected output? 
To see 5 snapshots

What do you see instead?
Around 15 snapshots are being created

[Mikhail Naganov]

Created attachment 48552 [details]
proposed fix

[Pavel Feldman]

Comment on attachment 48552 [details]
proposed fix

Minor nits, otherwise r+.

> +    this.lastRequestedLogPosition_ = -1;

this._lastRequestedLogPosition

> + */
> +devtools.ProfilerAgent.prototype.getNextLogLines_ = function(immediately)
> +{

"Next" does not sound well with plurals. "Further"?

> +    if (this.lastRequestedLogPosition_ == this.logPosition_)

===

Now that the files are upstream, please fix naming of private fields.

[Mikhail Naganov]

Created attachment 48554 [details]
make privates naming consistent with WebKit style

please don't put into cq, I'll commit myself

[Mikhail Naganov]

(In reply to comment #2)
> (From update of attachment 48552 [details])
> Minor nits, otherwise r+.
> 
> > +    this.lastRequestedLogPosition_ = -1;
> 
> this._lastRequestedLogPosition
> 
> > + */
> > +devtools.ProfilerAgent.prototype.getNextLogLines_ = function(immediately)
> > +{
> 
> "Next" does not sound well with plurals. "Further"?

Google for "next lines". To me, it looks OK.

> 
> > +    if (this.lastRequestedLogPosition_ == this.logPosition_)
> 
> ===
> 
> Now that the files are upstream, please fix naming of private fields.

Fixed

[Mikhail Naganov]

Manually committed r54667: http://trac.webkit.org/changeset/54667