Bug 34830 - Update webkit-patch modules to use User.prompt instead of raw_input and add optional support for repeated prompting for user input
Summary: Update webkit-patch modules to use User.prompt instead of raw_input and add o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 23:13 PST by Daniel Bates
Modified: 2010-02-11 18:00 PST (History)
2 users (show)

See Also:


Attachments
Patch with unit tests (7.76 KB, patch)
2010-02-11 08:29 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch with unit tests (8.32 KB, patch)
2010-02-11 08:41 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-02-10 23:13:47 PST
We should substitute the method User.prompt for raw_input throughout the various webkit-patch modules as well as add optional support for repeated prompting for user input.
Comment 1 Daniel Bates 2010-02-11 08:29:46 PST
Created attachment 48565 [details]
Patch with unit tests
Comment 2 Daniel Bates 2010-02-11 08:41:38 PST
Created attachment 48567 [details]
Patch with unit tests

Updated prototype of method MockUser.prompt to match User.prompt. Fixed spacing/new line issue at end of file in user_unittest.py. Updated change log.
Comment 3 Adam Barth 2010-02-11 13:58:39 PST
Comment on attachment 48567 [details]
Patch with unit tests

Very nice dependency injection.
Comment 4 Daniel Bates 2010-02-11 18:00:30 PST
Comment on attachment 48567 [details]
Patch with unit tests

Clearing flags on attachment: 48567

Committed r54693: <http://trac.webkit.org/changeset/54693>
Comment 5 Daniel Bates 2010-02-11 18:00:37 PST
All reviewed patches have been landed.  Closing bug.