Bug 34817 – run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory

[Eric Seidel (no email)]

Created attachment 48530 [details]
Patch

[Eric Seidel (no email)]

This patch at least makes it so that more people can run "run-chromium-webkit-tests --platform=mac-leopard" and have things work.  We're still a ways away from rcwt doing everything rwt does.

[Dirk Pranke]

Comment on attachment 48530 [details]
Patch

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
> index 5a770ef..c09ec37 100644
> --- a/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
> +++ b/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py
  
> @@ -265,6 +270,7 @@ class MacDriver(base.Driver):
>              # practice it shouldn't come up and the --help output warns
>              # about it anyway.
>              cmd += self._options.wrapper.split()
> +        # FIXME: Using arch here masks any possible file-not-found errors from a non-existant driver executable.
>          cmd += ['arch', '-i386', port._path_to_driver(), '-']

What you say is true, but you should still probably be calling arch -i386 $* (unless you want to dump the fat binary logic that currently is in run-webkit-tests

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
> index 4da32ad..83cf99d 100644
> --- a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
> +++ b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

did you mean to include this file?

-- dirk

[Eric Seidel (no email)]

Oh yeah, I'm not saying that "arch" is incorrect.  Just identifying that it is masking the missing file in case someone else runs into a similar error.

[Dirk Pranke]

patch LGTM otherwise.

[Eric Seidel (no email)]

Committed r54634: <http://trac.webkit.org/changeset/54634>