Bug 34815 - [Android] Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded[
Summary: [Android] Notifications and WebSockets generated headers in V8DOMWrapper.cpp ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 15:14 PST by Steve Block
Modified: 2010-02-11 05:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2010-02-11 04:01 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-10 15:14:34 PST
Notifications and WebSockets generated headers in V8DOMWrapper.cpp are not correctly guarded

These should be guarded with ENABLE(NOTIFICATIONS) and ENABLE(WEB_SOCKETS)
This was introduced in http://trac.webkit.org/changeset/54150
Comment 1 Steve Block 2010-02-11 04:01:50 PST
Created attachment 48556 [details]
Patch
Comment 2 Jeremy Orlow 2010-02-11 05:08:44 PST
Comment on attachment 48556 [details]
Patch

r=me because this seems to be what dave levin wanted...but I'm not sure if I agree this is better than putting guards around the includes.  Will bring it up in the other bug.
Comment 3 Steve Block 2010-02-11 05:29:45 PST
Comment on attachment 48556 [details]
Patch

Clearing flags on attachment: 48556

Committed r54653: <http://trac.webkit.org/changeset/54653>
Comment 4 Steve Block 2010-02-11 05:29:54 PST
All reviewed patches have been landed.  Closing bug.