Bug 34814 - [Android] XPath generated header in V8Proxy.cpp is not correctly guarded
Summary: [Android] XPath generated header in V8Proxy.cpp is not correctly guarded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 15:05 PST by Steve Block
Modified: 2010-02-11 05:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.07 KB, patch)
2010-02-10 15:07 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch (1.14 KB, patch)
2010-02-11 03:55 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-10 15:05:12 PST
XPath generated header in V8Proxy.cpp is not correctly guarded

This should be guarded with ENABLE(XPATH)
This was introduced in http://trac.webkit.org/changeset/54305
Comment 1 Steve Block 2010-02-10 15:07:24 PST
Created attachment 48520 [details]
Patch
Comment 2 David Levin 2010-02-10 15:14:42 PST
Comment on attachment 48520 [details]
Patch

This shouldn't be done (see my comments in the last review). The header already has the ENABLE guard in it.

(In addition ENEABLE is spelled incorrectly.)
Comment 3 Steve Block 2010-02-11 03:55:15 PST
Created attachment 48555 [details]
Patch
Comment 4 Steve Block 2010-02-11 03:55:54 PST
Updated patch to reflect discussion in Bug 34812
Comment 5 Jeremy Orlow 2010-02-11 05:17:09 PST
Comment on attachment 48555 [details]
Patch

r=me per Dave Levin's direction in the other bug (i.e. I think this is the wrong direction)
Comment 6 Steve Block 2010-02-11 05:27:36 PST
Comment on attachment 48555 [details]
Patch

Clearing flags on attachment: 48555

Committed r54652: <http://trac.webkit.org/changeset/54652>
Comment 7 Steve Block 2010-02-11 05:27:49 PST
All reviewed patches have been landed.  Closing bug.