RESOLVED FIXED 34814
[Android] XPath generated header in V8Proxy.cpp is not correctly guarded 
https://bugs.webkit.org/show_bug.cgi?id=34814
Summary [Android] XPath generated header in V8Proxy.cpp is not correctly guarded
Steve Block
Reported 2010-02-10 15:05:12 PST
XPath generated header in V8Proxy.cpp is not correctly guarded This should be guarded with ENABLE(XPATH) This was introduced in http://trac.webkit.org/changeset/54305
Attachments
Patch (1.07 KB, patch)
2010-02-10 15:07 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2010-02-11 03:55 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-02-10 15:07:24 PST
Created attachment 48520 [details] Patch
David Levin
Comment 2 2010-02-10 15:14:42 PST
Comment on attachment 48520 [details] Patch This shouldn't be done (see my comments in the last review). The header already has the ENABLE guard in it. (In addition ENEABLE is spelled incorrectly.)
Steve Block
Comment 3 2010-02-11 03:55:15 PST
Created attachment 48555 [details] Patch
Steve Block
Comment 4 2010-02-11 03:55:54 PST
Updated patch to reflect discussion in Bug 34812
Jeremy Orlow
Comment 5 2010-02-11 05:17:09 PST
Comment on attachment 48555 [details] Patch r=me per Dave Levin's direction in the other bug (i.e. I think this is the wrong direction)
Steve Block
Comment 6 2010-02-11 05:27:36 PST
Comment on attachment 48555 [details] Patch Clearing flags on attachment: 48555 Committed r54652: <http://trac.webkit.org/changeset/54652>
Steve Block
Comment 7 2010-02-11 05:27:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.