Bug 34806 - [Android] Inspector headers in V8 ScriptObject.cpp are not correctly guarded
Summary: [Android] Inspector headers in V8 ScriptObject.cpp are not correctly guarded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 11:00 PST by Steve Block
Modified: 2010-02-11 03:41 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2010-02-10 11:04 PST, Steve Block
japhet: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-10 11:00:44 PST
Inspector headers in V8 ScriptObject.cpp are not correctly guarded

These are generated headers so need to be guarded by ENABLE(INSPECTOR)
They were added in http://trac.webkit.org/changeset/54305
Comment 1 Steve Block 2010-02-10 11:04:34 PST
Created attachment 48510 [details]
Patch
Comment 2 Nate Chapin 2010-02-10 11:26:40 PST
Comment on attachment 48510 [details]
Patch

Sorry for breaking you :(
Comment 3 Steve Block 2010-02-10 16:15:29 PST
Comment on attachment 48510 [details]
Patch

Will update patch to avoid use of guards at header include sites. See Bug 34812.
Comment 4 Steve Block 2010-02-11 03:41:53 PST
Landed updated patch as http://trac.webkit.org/changeset/54651

Closing bug as resolved fixed.