Bug 34805 – [V8] Perf regression in V8DOMWrapper::instantiateV8Object()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nate Chapin]

I introduced a performance regression in http://trac.webkit.org/changeset/54499.

It can be fixed by providing a split similar to what had existed previously: one path for objects that might be constructed in a WorkerContext, and a fast path for objects that are never in a WorkerContext.

[Nate Chapin]

Created attachment 48512 [details]
patch

Performance on the DOM benchmark suite with this patch is comparable to a build with 54499 reverted, and dromaeo performance appears to be slightly better.

[anton muhin]

Thanks a lot, Nate.

Only one thing---instantiate in worker context tells me that it must be a worker context, however it looks like it's possibly a worker context.

If it's correct, could you give some other name.  The ugly idea I have is in possible worker context.

[Nate Chapin]

(In reply to comment #2)
> Thanks a lot, Nate.
> 
> Only one thing---instantiate in worker context tells me that it must be a
> worker context, however it looks like it's possibly a worker context.
> 
> If it's correct, could you give some other name.  The ugly idea I have is in
> possible worker context.

Yeah, I debated the name.  Perhaps instantiateV8ObjectMaybeInWorkerContext?

[anton muhin]

(In reply to comment #3)
> (In reply to comment #2)
> > Thanks a lot, Nate.
> > 
> > Only one thing---instantiate in worker context tells me that it must be a
> > worker context, however it looks like it's possibly a worker context.
> > 
> > If it's correct, could you give some other name.  The ugly idea I have is in
> > possible worker context.
> 
> Yeah, I debated the name.  Perhaps instantiateV8ObjectMaybeInWorkerContext?

Yep, something like that.  Thanks.

[Dimitri Glazkov (Google)]

Comment on attachment 48512 [details]
patch

ok. I was so happy for this code to be gone. Oh well.

[Nate Chapin]

http://trac.webkit.org/changeset/54680