Bug 34789 - Roll Chromium dependencies
Summary: Roll Chromium dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 02:52 PST by Yury Semikhatsky
Modified: 2010-02-10 07:30 PST (History)
3 users (show)

See Also:


Attachments
patch (1.33 KB, patch)
2010-02-10 03:08 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
patch (1.05 KB, patch)
2010-02-10 05:54 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
patch (1.20 KB, patch)
2010-02-10 06:45 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
patch (1.19 KB, patch)
2010-02-10 07:12 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-02-10 02:52:07 PST
WebKit/chromium/DEPS hasn't been updated for awhile.
Comment 1 Yury Semikhatsky 2010-02-10 03:08:41 PST
Created attachment 48479 [details]
patch

Rolling Chromium dependencies to match Chromium revision 38580
Comment 2 Pavel Feldman 2010-02-10 03:11:16 PST
Comment on attachment 48479 [details]
patch

I believe these figures changed for a good reason :P
Comment 3 Yury Semikhatsky 2010-02-10 03:15:48 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/DEPS
Committed r54594
Comment 4 Yury Semikhatsky 2010-02-10 05:54:54 PST
Created attachment 48495 [details]
patch

base.gypi depends on third_party/nss on Windows(see http://src.chromium.org/viewvc/chrome?view=rev&revision=37289). This dependency breaks Chromium WebKit API build on Windows so I'm adding it to the DEPS.
Comment 5 Adam Langley 2010-02-10 06:07:57 PST
If you already have a dependency on base, why isn't that sufficient to pull in NSS? What actually breaks?
Comment 6 Yury Semikhatsky 2010-02-10 06:33:45 PST
(In reply to comment #5)
> If you already have a dependency on base, why isn't that sufficient to pull in
> NSS? What actually breaks?
The problem is that NSS is not checked out in WebKit Chromium port build:

http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio
Comment 7 Yury Semikhatsky 2010-02-10 06:45:19 PST
Created attachment 48500 [details]
patch
Comment 8 Adam Langley 2010-02-10 06:53:04 PST
> The problem is that NSS is not checked out in WebKit Chromium port build:
> 
> http://build.webkit.org/builders/Chromium%20Win%20Release/builds/2082/steps/gclient/logs/stdio

Oh I see. Ok, thanks. LGTM. I am not a WebKit reviewer but, since this is a build break, you can just land it. (Or I can land it for you if you need.)
Comment 9 Yury Semikhatsky 2010-02-10 07:12:47 PST
Created attachment 48503 [details]
patch

Same patch with nss URL fix.
Comment 10 Yury Semikhatsky 2010-02-10 07:22:46 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/DEPS
Committed r54598