Bug 34786 – [Gtk] Make WebKit build on s390(x)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Stransky]

Created attachment 48469 [details]
s390(x) build patch

Hi,

there is a patch attached we use to build webkit on s390(x) boxes.

[Martin Stransky]

For clarification:

__s390x__ is 64bit
__s390__  is 32bit

and both are BIG_ENDIAN platform.

[Julien Chaffraix]

Thanks for the patch. Though you should follow http://webkit.org/coding/contributing.html if you want your patch to be integrated.
First make sure that you have a ChangeLog that explains the endian-ness issue. Also make sure you set the review flag to '?' or no reviewer will have a look at it.

[Martin Robinson]

Martin, would you be willing to provide an updated patch for this issue against the SVN repository?

[Dan Horák]

Created attachment 73597 [details]
add support for s390(x)

rebased to recent SVN trunk

[Andreas Kling]

Comment on attachment 73597 [details]
add support for s390(x)

LGTM.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73597 [details]:

fast/css/font-face-download-error.html
http/tests/appcache/foreign-fallback.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73597 [details]:

scrollbars/scrollbar-iframe-click-does-not-blur-content.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73597 [details]
add support for s390(x)

Clearing flags on attachment: 73597

Committed r71844: <http://trac.webkit.org/changeset/71844>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71844 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/workers/storage/interrupt-database-sync.html