WebSocket in Worker failed to close.
Created attachment 48466 [details] Patch
Comment on attachment 48466 [details] Patch > +# Copyright 2009, Google Inc. 2010. Could this typo cause crashes? If not, is the "if (m_bridge)" check necessary at all? And if it could, is it possible to make a regression test for the crash? r=me
Please feel free to CC me on WebSocket bugs.
Committed r54692: <http://trac.webkit.org/changeset/54692>
(In reply to comment #2) > (From update of attachment 48466 [details]) > > +# Copyright 2009, Google Inc. > > 2010. > > Could this typo cause crashes? If not, is the "if (m_bridge)" check necessary > at all? And if it could, is it possible to make a regression test for the > crash? I believe it could cause crashes, and "if (m_bridge)" might not be necessary and it's just defensive. should we use assert instead?
Yes, If it's not necessary, it probably shouldn't be there. I don't think an assertion would be very useful - a crash on the next line is just as good.