Fix two issues on maxLength.
Created attachment 48461 [details] Proposed patch
Comment on attachment 48461 [details] Proposed patch > +debug('<br />Non-dirty value'); It's better not to rely on markup in the debug function. I typically use debug('') to make a blank line. Someone should clean this up a bit for future tests. The setNonDirtyValue affects a lot of different functions. There is not sufficient test coverage for this. Each function that you changed to call setNonDirtyValue needs a test that would fail if it was still calling setValue. I'm going to say review- because of not enough test coverage. Everything else seems OK in the patch. If I'm wrong about the test coverage, please let me know.
Created attachment 48553 [details] Proposed patch (rev.2)
(In reply to comment #2) > (From update of attachment 48461 [details]) > > +debug('<br />Non-dirty value'); Fixed. > The setNonDirtyValue affects a lot of different functions. There is not > sufficient test coverage for this. Each function that you changed to call > setNonDirtyValue needs a test that would fail if it was still calling setValue. ok, I added tests to cover affected functions.
Comment on attachment 48553 [details] Proposed patch (rev.2) Clearing flags on attachment: 48553 Committed r54695: <http://trac.webkit.org/changeset/54695>
All reviewed patches have been landed. Closing bug.