RESOLVED FIXED Bug 34768
[V8] Remove references to V8ClassIndex when possible 
https://bugs.webkit.org/show_bug.cgi?id=34768
Summary [V8] Remove references to V8ClassIndex when possible
Nate Chapin
Reported 2010-02-09 11:30:33 PST
There are a bunch of places where we pass around V8ClassIndex::V8WrapperType parameters where we could (and probably should) be passing around other things that don't require a later lookup. Usually this means passing a v8::Handle<v8::FunctionTemplate> instead.
Attachments
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() (21.06 KB, patch)
2010-02-09 11:31 PST, Nate Chapin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2010-02-09 11:31:12 PST
Created attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()
Adam Barth
Comment 2 2010-02-09 12:07:18 PST
Comment on attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() Great. I've never liked V8ClassIndex. Seemed so wrong to have a global list of classes like that.
Nate Chapin
Comment 3 2010-02-10 16:10:28 PST
Comment on attachment 48430 [details] Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() http://trac.webkit.org/changeset/54629
Nate Chapin
Comment 4 2010-03-10 14:56:49 PST
I think most of the unnecessary references to V8ClassIndex have been removed, and the rest are feasible to take care of in the patch that deletes V8Index.h.
Note You need to log in before you can comment on or make changes to this bug.