Bug 34768 - [V8] Remove references to V8ClassIndex when possible
Summary: [V8] Remove references to V8ClassIndex when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 33477
  Show dependency treegraph
 
Reported: 2010-02-09 11:30 PST by Nate Chapin
Modified: 2010-03-10 14:56 PST (History)
0 users

See Also:


Attachments
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper() (21.06 KB, patch)
2010-02-09 11:31 PST, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-02-09 11:30:33 PST
There are a bunch of places where we pass around V8ClassIndex::V8WrapperType parameters where we could (and probably should) be passing around other things that don't require a later lookup.  Usually this means passing a v8::Handle<v8::FunctionTemplate> instead.
Comment 1 Nate Chapin 2010-02-09 11:31:12 PST
Created attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()
Comment 2 Adam Barth 2010-02-09 12:07:18 PST
Comment on attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

Great.  I've never liked V8ClassIndex.  Seemed so wrong to have a global list of classes like that.
Comment 3 Nate Chapin 2010-02-10 16:10:28 PST
Comment on attachment 48430 [details]
Remove V8ClassIndex from configureTemplate() and lookupDOMWrapper()

http://trac.webkit.org/changeset/54629
Comment 4 Nate Chapin 2010-03-10 14:56:49 PST
I think most of the unnecessary references to V8ClassIndex have been removed, and the rest are feasible to take care of in the patch that deletes V8Index.h.