WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34759
wx port: windows port complex text support
https://bugs.webkit.org/show_bug.cgi?id=34759
Summary
wx port: windows port complex text support
Kevin Watters
Reported
2010-02-09 09:52:40 PST
Created
attachment 48426
[details]
implement complex text support on wxMSW The wxMSW port could share UniscribeController from the Windows port to support complex text paths.
Attachments
implement complex text support on wxMSW
(21.47 KB, patch)
2010-02-09 09:52 PST
,
Kevin Watters
kevino
: review+
kevino
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2010-02-09 09:53:31 PST
Attachment 48426
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/wx/wxcode/mac/carbon/fontprops.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/wx/wxcode/gtk/fontprops.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/wx/wxcode/win/fontprops.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 If any of these errors are false positives, please file a bug against check-webkit-style.
Kevin Ollivier
Comment 2
2010-02-10 18:13:44 PST
Landed in
r54635
, thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug