Bug 34754 - [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
Summary: [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-09 07:47 PST by Xan Lopez
Modified: 2010-02-09 10:23 PST (History)
1 user (show)

See Also:


Attachments
setadjforframeview.diff (4.12 KB, patch)
2010-02-09 07:52 PST, Xan Lopez
gns: review+
xan.lopez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-02-09 07:47:56 PST
Right now we only do this in FrameLoaderClient::transitionToCommittedForNewPage, which is only called when we load uncached pages. If the page we are about to load is in the cache rameLoaderClient::transitionToCommittedFromCachedFrame is called instead, and we never set the adjustments. This results in the scrollbars for the main frame being mispositioned and nonfunctional in some cases.
Comment 1 Xan Lopez 2010-02-09 07:52:59 PST
Created attachment 48414 [details]
setadjforframeview.diff
Comment 2 WebKit Review Bot 2010-02-09 07:55:58 PST
Attachment 48414 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1131:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1142:  Declaration has space between type name and * in Frame *frame  [whitespace/declaration] [3]
Total errors found: 2


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gustavo Noronha (kov) 2010-02-09 10:18:59 PST
Comment on attachment 48414 [details]
setadjforframeview.diff

r=me with the style issues reported by the bot fixed! =)
Comment 4 Xan Lopez 2010-02-09 10:23:43 PST
All done in r54559.