WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 34747
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=34747
Summary
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
Andreas Kling
Reported
2010-02-09 03:53:06 PST
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
Attachments
Patch
(8.60 KB, patch)
2010-02-09 04:00 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch with comment + reference to original source
(8.73 KB, patch)
2010-02-09 05:20 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2010-02-09 04:00:51 PST
Created
attachment 48404
[details]
Patch
Kenneth Rohde Christiansen
Comment 2
2010-02-09 04:48:27 PST
Comment on
attachment 48404
[details]
Patch
> +bool qt_sendSpontaneousEvent(QObject* receiver, QEvent* ev) > +{ > + return QCoreApplication::sendSpontaneousEvent(receiver, ev); > +}
Why is this needed? Are you wrapping a method with the same signature
> + Patch by Robert Griebl <
rgriebl@trolltech.com
>
As far as I understand, Robert is the committer, but the patch was done by Sandmann,
Andreas Kling
Comment 3
2010-02-09 05:20:24 PST
Created
attachment 48407
[details]
Patch with comment + reference to original source
Kenneth Rohde Christiansen
Comment 4
2010-02-09 05:24:00 PST
Comment on
attachment 48407
[details]
Patch with comment + reference to original source
> -class QWebViewKineticScroller : public QAbstractKineticScroller { > +// QCoreApplication::sendSpontaneousEvent() is private, hence this friend wrapper > +bool qt_sendSpontaneousEvent(QObject* receiver, QEvent* ev) > +{ > + return QCoreApplication::sendSpontaneousEvent(receiver, ev); > +}
So this means that I cannot use QAbstractKineticScroller with the graphicswebview because I do not have access to this method?
WebKit Commit Bot
Comment 5
2010-02-09 17:44:05 PST
Comment on
attachment 48407
[details]
Patch with comment + reference to original source Clearing flags on attachment: 48407 Committed
r54575
: <
http://trac.webkit.org/changeset/54575
>
WebKit Commit Bot
Comment 6
2010-02-09 17:44:11 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug