Bug 34747 - [Qt] Sync with API changes in Maemo 5 kinetic scrolling
Summary: [Qt] Sync with API changes in Maemo 5 kinetic scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-09 03:53 PST by Andreas Kling
Modified: 2010-02-09 17:44 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.60 KB, patch)
2010-02-09 04:00 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch with comment + reference to original source (8.73 KB, patch)
2010-02-09 05:20 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-02-09 03:53:06 PST
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
Comment 1 Andreas Kling 2010-02-09 04:00:51 PST
Created attachment 48404 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-02-09 04:48:27 PST
Comment on attachment 48404 [details]
Patch


> +bool qt_sendSpontaneousEvent(QObject* receiver, QEvent* ev)
> +{
> +    return QCoreApplication::sendSpontaneousEvent(receiver, ev);
> +}

Why is this needed? Are you wrapping a method with the same signature


> +        Patch by Robert Griebl <rgriebl@trolltech.com>

As far as I understand, Robert is the committer, but the patch was done by Sandmann,
Comment 3 Andreas Kling 2010-02-09 05:20:24 PST
Created attachment 48407 [details]
Patch with comment + reference to original source
Comment 4 Kenneth Rohde Christiansen 2010-02-09 05:24:00 PST
Comment on attachment 48407 [details]
Patch with comment + reference to original source


> -class QWebViewKineticScroller : public QAbstractKineticScroller {
> +// QCoreApplication::sendSpontaneousEvent() is private, hence this friend wrapper
> +bool qt_sendSpontaneousEvent(QObject* receiver, QEvent* ev)
> +{
> +    return QCoreApplication::sendSpontaneousEvent(receiver, ev);
> +}

So this means that I cannot use QAbstractKineticScroller with the graphicswebview because I do not have access to this method?
Comment 5 WebKit Commit Bot 2010-02-09 17:44:05 PST
Comment on attachment 48407 [details]
Patch with comment + reference to original source

Clearing flags on attachment: 48407

Committed r54575: <http://trac.webkit.org/changeset/54575>
Comment 6 WebKit Commit Bot 2010-02-09 17:44:11 PST
All reviewed patches have been landed.  Closing bug.