Bug 34727 - Assertion crashes and freezes when plug-in property access results in an exception
Summary: Assertion crashes and freezes when plug-in property access results in an exce...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-02-08 14:57 PST by Alexey Proskuryakov
Modified: 2010-02-09 12:14 PST (History)
0 users

See Also:


Attachments
proposed fix (18.24 KB, patch)
2010-02-08 15:15 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-02-08 14:57:01 PST
Our code isn't prepared to plug-in calling NPN_SetException during property access.
Comment 1 Alexey Proskuryakov 2010-02-08 15:15:58 PST
Created attachment 48367 [details]
proposed fix
Comment 2 Darin Adler 2010-02-08 15:18:59 PST
Comment on attachment 48367 [details]
proposed fix

>      static void setGlobalException(JSC::UString exception);

Maybe this argument name should be a const &, but that's not new to your code.

> +    static void moveGlobalExceptionToExecState(ExecState* exec);

You should omit the argument name there.

r=me
Comment 3 Alexey Proskuryakov 2010-02-08 15:28:05 PST
Committed <http://trac.webkit.org/changeset/54516>.
Comment 4 Alexey Proskuryakov 2010-02-09 12:14:41 PST
<rdar://problem/7124241>