Bug 34706 - Web Inspector: Continue with debugger and profiler unforking
Summary: Web Inspector: Continue with debugger and profiler unforking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-08 09:04 PST by Mikhail Naganov
Modified: 2010-02-09 18:02 PST (History)
10 users (show)

See Also:


Attachments
proposed patch (24.42 KB, patch)
2010-02-08 09:07 PST, Mikhail Naganov
pfeldman: review-
Details | Formatted Diff | Diff
comment addressed, removed style changes, fixed chromium port (14.83 KB, patch)
2010-02-09 04:15 PST, Mikhail Naganov
no flags Details | Formatted Diff | Diff
really fixed chromimum port (15.53 KB, patch)
2010-02-09 05:10 PST, Mikhail Naganov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-02-08 09:04:43 PST
Narrow scope of JSC-specific ifdefs.

Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required for really enabling it in V8 bindings generation.
Comment 1 Mikhail Naganov 2010-02-08 09:07:58 PST
Created attachment 48335 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-02-08 09:16:38 PST
Attachment 48335 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/244785
Comment 3 Pavel Feldman 2010-02-08 09:49:00 PST
Comment on attachment 48335 [details]
proposed patch

r- for the bot failure.

+ #elif ENABLE(JAVASCRIPT_DEBUGGER)
+     , m_profilerEnabled(true)

It would be more clear if m_profilerEnabled was mentioned only once and resided in a simple ENABLE(JAVASCRIPT_DEBUGGER) section.

Also please do not mix formatting with changes that heavily.
Comment 4 Mikhail Naganov 2010-02-09 04:15:24 PST
Created attachment 48405 [details]
comment addressed, removed style changes, fixed chromium port
Comment 5 WebKit Review Bot 2010-02-09 04:54:50 PST
Attachment 48405 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/250407
Comment 6 Mikhail Naganov 2010-02-09 05:10:08 PST
Created attachment 48406 [details]
really fixed chromimum port
Comment 7 WebKit Commit Bot 2010-02-09 18:02:37 PST
Comment on attachment 48406 [details]
really fixed chromimum port

Clearing flags on attachment: 48406

Committed r54576: <http://trac.webkit.org/changeset/54576>
Comment 8 WebKit Commit Bot 2010-02-09 18:02:49 PST
All reviewed patches have been landed.  Closing bug.