RESOLVED FIXED Bug 34706
Web Inspector: Continue with debugger and profiler unforking 
https://bugs.webkit.org/show_bug.cgi?id=34706
Summary Web Inspector: Continue with debugger and profiler unforking
Mikhail Naganov
Reported 2010-02-08 09:04:43 PST
Narrow scope of JSC-specific ifdefs. Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required for really enabling it in V8 bindings generation.
Attachments
proposed patch (24.42 KB, patch)
2010-02-08 09:07 PST, Mikhail Naganov 		pfeldman: review-
DetailsFormatted DiffDiff
comment addressed, removed style changes, fixed chromium port (14.83 KB, patch)
2010-02-09 04:15 PST, Mikhail Naganov 		no flags
DetailsFormatted DiffDiff
really fixed chromimum port (15.53 KB, patch)
2010-02-09 05:10 PST, Mikhail Naganov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2010-02-08 09:07:58 PST
Created attachment 48335 [details] proposed patch
WebKit Review Bot
Comment 2 2010-02-08 09:16:38 PST
Attachment 48335 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/244785
Pavel Feldman
Comment 3 2010-02-08 09:49:00 PST
Comment on attachment 48335 [details] proposed patch r- for the bot failure. + #elif ENABLE(JAVASCRIPT_DEBUGGER) + , m_profilerEnabled(true) It would be more clear if m_profilerEnabled was mentioned only once and resided in a simple ENABLE(JAVASCRIPT_DEBUGGER) section. Also please do not mix formatting with changes that heavily.
Mikhail Naganov
Comment 4 2010-02-09 04:15:24 PST
Created attachment 48405 [details] comment addressed, removed style changes, fixed chromium port
WebKit Review Bot
Comment 5 2010-02-09 04:54:50 PST
Attachment 48405 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/250407
Mikhail Naganov
Comment 6 2010-02-09 05:10:08 PST
Created attachment 48406 [details] really fixed chromimum port
WebKit Commit Bot
Comment 7 2010-02-09 18:02:37 PST
Comment on attachment 48406 [details] really fixed chromimum port Clearing flags on attachment: 48406 Committed r54576: <http://trac.webkit.org/changeset/54576>
WebKit Commit Bot
Comment 8 2010-02-09 18:02:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.