Bug 34704 - [v8] Use v8::Debug::ProcessDebugMessages instead of executing an empty function
Summary: [v8] Use v8::Debug::ProcessDebugMessages instead of executing an empty function
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on:
Reported: 2010-02-08 05:40 PST by Yury Semikhatsky
Modified: 2010-02-10 02:26 PST (History)
3 users (show)

See Also:

patch (5.68 KB, patch)
2010-02-08 05:43 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
patch that I'm going to land (10.82 KB, patch)
2010-02-10 00:23 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-02-08 05:40:44 PST
v8 API now has a method for forcing debug command processing. We should use it instead of executing empty function to trigger JS execution.
Comment 1 Yury Semikhatsky 2010-02-08 05:43:45 PST
Created attachment 48328 [details]
Comment 2 WebKit Review Bot 2010-02-08 05:58:10 PST
Attachment 48328 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/245261
Comment 3 Yury Semikhatsky 2010-02-10 00:23:18 PST
Created attachment 48470 [details]
patch that I'm going to land

The patch includes changes to the recently upstreamed *.js files.
Comment 4 Yury Semikhatsky 2010-02-10 02:26:11 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/DebuggerAgent.h
	M	WebKit/chromium/src/DebuggerAgentImpl.cpp
	M	WebKit/chromium/src/DebuggerAgentImpl.h
	M	WebKit/chromium/src/ToolsAgent.h
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
	M	WebKit/chromium/src/WebDevToolsAgentImpl.h
	M	WebKit/chromium/src/js/DebuggerAgent.js
	M	WebKit/chromium/src/js/DevToolsHostStub.js
	M	WebKit/chromium/src/js/InjectDispatch.js
	M	WebKit/chromium/src/js/ProfilerAgent.js
	M	WebKit/chromium/src/js/Tests.js
Committed r54592