Bug 34702 – [Qt] Make possible Qt DRT dump frame load callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Diego Gonzalez]

Implement dumpFrameLoadCallbacks in LayoutTestController

LayoutTests:
http/tests/security/mixedContent

[Diego Gonzalez]

The main point of this bugs is to find the exactly place to enable the dump frame loader callbacks. I'm doing some tests and getting some differences with
the expected results.
I'm investigating how to sync the Qt dumpFrameLoadCallbacks() with the expected results and evaluating the possibility to make specifics results for Qt port.

[Diego Gonzalez]

Created attachment 48497 [details]
Active dump frame loader callbacks

[Diego Gonzalez]

Activating the dumpFrameLoadCallbacks the following LayoutTest now pass:

http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

[Diego Gonzalez]

The fallowing tests are still failing:

http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html

Needs to evaluate the expected files are correct for Qt or there
is a sync problem to get the results as expected. There is a pattern in the results
of failed tests.

the tests:
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html

have the added two more lines as expected:
+main frame - didFailProvisionalLoadWithError
+main frame - didStartProvisionalLoadForFrame

the tests:
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html

also have the lines:
+main frame - didFailProvisionalLoadWithError
+main frame - didStartProvisionalLoadForFrame

but is missing the:
-main frame - didFinishLoadForFrame

The Qt FrameLoaderClient should be investigated more to get results difference
reason.

[Diego Gonzalez]

(In reply to comment #4)
> The fallowing tests are still failing:
> 
> http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
> http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
> http/tests/security/mixedContent/insecure-css-in-main-frame.html
> http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
> http/tests/security/mixedContent/insecure-image-in-main-frame.html
> http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
> http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
> 
> Needs to evaluate the expected files are correct for Qt or there
> is a sync problem to get the results as expected. There is a pattern in the
> results
> of failed tests.
> 
> the tests:
> http/tests/security/mixedContent/insecure-css-in-main-frame.html
> http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
> 
> have the added two more lines as expected:
> +main frame - didFailProvisionalLoadWithError
> +main frame - didStartProvisionalLoadForFrame
> 
> the tests:
> http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
> http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
> http/tests/security/mixedContent/insecure-image-in-main-frame.html
> http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
> http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
> 
> also have the lines:
> +main frame - didFailProvisionalLoadWithError
> +main frame - didStartProvisionalLoadForFrame
> 
> but is missing the:
> -main frame - didFinishLoadForFrame
> 
> The Qt FrameLoaderClient should be investigated more to get results difference
> reason.

created another bug to investigate this resolts:
https://bugs.webkit.org/show_bug.cgi?id=34839

[Diego Gonzalez]

Created attachment 48559 [details]
Proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 48559 [details]
Proposed patch

You rock Diego!

[WebKit Commit Bot]

Comment on attachment 48559 [details]
Proposed patch

Rejecting patch 48559 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12150 test cases.
websocket/tests/bufferedAmount-after-close.html -> crashed

Exiting early after 1 failures. 12118 tests run.
519.04s total testing time

12117 test cases (99%) succeeded
1 test case (<1%) crashed
7 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/259586

[Antonio Gomes]

Comment on attachment 48559 [details]
Proposed patch

hum, the failing reason below seems very unrelated to this patch. lets hope it was a bot failure and give it one more change.


*****************
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari',
'--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12150 test cases.
websocket/tests/bufferedAmount-after-close.html -> crashed

Exiting early after 1 failures. 12118 tests run.
519.04s total testing time

12117 test cases (99%) succeeded
1 test case (<1%) crashed
7 test cases (<1%) had stderr output

[WebKit Commit Bot]

Comment on attachment 48559 [details]
Proposed patch

Clearing flags on attachment: 48559

Committed r54723: <http://trac.webkit.org/changeset/54723>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Crash was bug 34898.