RESOLVED FIXED Bug 34697
Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric value in CSS property takes focus away 
https://bugs.webkit.org/show_bug.cgi?id=34697
Summary Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric value...
mitz
Reported 2010-02-07 23:28:06 PST
When editing a numeric value of a CSS property, pressing the up arrow key or the down arrow key increments or decrements the value as expected, but then takes focuses the outline view on the left pane and terminates editing.
Attachments
[PATCH] Proposed fix. (1.52 KB, patch)
2010-03-09 10:25 PST, Pavel Feldman 		timothy: review+
pfeldman: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-03-09 09:44:18 PST
It works for me. Any particular use case?
mitz
Comment 2 2010-03-09 10:04:36 PST
(In reply to comment #1) > It works for me. Any particular use case? For example, in <data:text/html,%3Cbody%20style=%22margin-top:%201px%22%3E> editing the margin property of the body element.
Pavel Feldman
Comment 3 2010-03-09 10:25:31 PST
Created attachment 50325 [details] [PATCH] Proposed fix. I just removed elements panel's update that was revealing and selecting currently selected node (that was stealing focus due to generic implementation). I am not sure why that update was there at the first place - we've never reflected style updates in elements' attributes.
Timothy Hatcher
Comment 4 2010-03-09 12:15:30 PST
Comment on attachment 50325 [details] [PATCH] Proposed fix. Do we loose anything by not doing this anymore?
Pavel Feldman
Comment 5 2010-03-09 13:02:34 PST
(In reply to comment #4) > (From update of attachment 50325 [details]) > Do we loose anything by not doing this anymore? I can't think of anything. Was hoping for you to bring something up.
Timothy Hatcher
Comment 6 2010-03-09 13:03:34 PST
It might predate the time when we had the DOM attrs update when changed.
Pavel Feldman
Comment 7 2010-03-09 13:05:46 PST
(In reply to comment #6) > It might predate the time when we had the DOM attrs update when changed. This must have been prior to 4.0.4.
Pavel Feldman
Comment 8 2010-03-09 22:13:14 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js Committed r55764
Note You need to log in before you can comment on or make changes to this bug.