* Some compiler warnings were fixed. * Wrong coordinates were extracted from the Haiku event BMessage, resulting in an offset for mouse moved events. * Improved the compatibility of keyboard events. * Use the correct code for the tab/backspace key in EventHandlerHaiku.cpp and fix the build by not including PlatformScrollBar.h * Generate a correct timestamp for mouse/wheel events. The value is documented as being in seconds. * Fill the modifier flags in mouse/wheel events.
Created attachment 48298 [details] Various fixes to mouse/wheel/keyboard event propagation on Haiku Patch against r54275, but touches only Haiku code.
Comment on attachment 48298 [details] Various fixes to mouse/wheel/keyboard event propagation on Haiku 39 #include <stdio.h> seems wrong. The EWS bots seem to think this patch does not apply. Marking it cq-.
Hi Eric, What is the next step on this now? Remove the #include <stdio.h> line and make a new patch against the latest WebKit? Though considering this only touches Haiku-specific files it should not matter what version of WebKit a patch is made against since no one else is touching our port. I'm also a bit confused as to why the EWS bots would think this patch does not apply, since again it only touches our port code. Assuming that happens again can someone apply this manually?
You can click on the purple bubbles to see the EWS bot results: Failed to run "['/mnt/git/webkit-chromium-ews/WebKitTools/Scripts/svn-apply', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/page/haiku/EventHandlerHaiku.cpp patching file WebCore/platform/haiku/PlatformKeyboardEventHaiku.cpp patching file WebCore/platform/haiku/PlatformMouseEventHaiku.cpp patching file WebCore/platform/haiku/PlatformWheelEventHaiku.cpp Hunk #3 FAILED at 40. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/platform/haiku/PlatformWheelEventHaiku.cpp.rej
Created attachment 48973 [details] Fix various issues of PlatformMouseEventHaiku.cpp Smaller patch covering just PlatformMouseEventHaiku.cpp. Patch is against r54932.
Created attachment 48976 [details] Some fixes to PlatformWheelEventHaiku.cpp Smaller patch for just the PlatformWheelEventHaiku.cpp fixes.
Created attachment 48977 [details] Fixes to PlatformKeyboardEventHaiku.cpp Smaller patch for just PlatformKeyboardEventHaiku.cpp. Patch against r54932.
Created attachment 48979 [details] Various improvements to EventHandlerHaiku.cpp Smaller patch for just EventHandlerHaiku.cpp. Patch against r54938. Compared to the original patch, the methods have been implemented according to the Gtk port, and the non-implemented passSubframeEventToSubframe() method, which all the other methods called, has been removed.
Comment on attachment 48973 [details] Fix various issues of PlatformMouseEventHaiku.cpp OK. mostly rs=me.
Comment on attachment 48976 [details] Some fixes to PlatformWheelEventHaiku.cpp These tiny patches are *sooooo* much easier to review, thank you!
Comment on attachment 48977 [details] Fixes to PlatformKeyboardEventHaiku.cpp Sad that this same code is copy/paste in all 3 platform events: int32 modifiers = message->FindInt32("modifiers"); 351 m_shiftKey = modifiers & B_SHIFT_KEY; 352 m_ctrlKey = modifiers & B_COMMAND_KEY; 353 m_altKey = modifiers & B_CONTROL_KEY; 354 m_metaKey = modifiers & B_OPTION_KEY; Looks good.
Comment on attachment 48979 [details] Various improvements to EventHandlerHaiku.cpp OK.
Comment on attachment 48973 [details] Fix various issues of PlatformMouseEventHaiku.cpp Clearing flags on attachment: 48973 Committed r55116: <http://trac.webkit.org/changeset/55116>
Comment on attachment 48976 [details] Some fixes to PlatformWheelEventHaiku.cpp Clearing flags on attachment: 48976 Committed r55130: <http://trac.webkit.org/changeset/55130>
Comment on attachment 48977 [details] Fixes to PlatformKeyboardEventHaiku.cpp Clearing flags on attachment: 48977 Committed r55138: <http://trac.webkit.org/changeset/55138>
Comment on attachment 48979 [details] Various improvements to EventHandlerHaiku.cpp Clearing flags on attachment: 48979 Committed r55145: <http://trac.webkit.org/changeset/55145>
All reviewed patches have been landed. Closing bug.