Add dummy Cursor copied from android.
Created attachment 48281 [details] Patch
Attachment 48281 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/brew/CursorBrew.cpp:302: Place brace on its own line for function definitions. [whitespace/braces] [4] WebCore/platform/brew/CursorBrew.cpp:307: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 48283 [details] Patch Fix style errors.
Comment on attachment 48283 [details] Patch Global statics are very much frowned upon in WebKit. They'll slow down your load time if nothing else.
Created attachment 48499 [details] Patch Don't use global statics. Create a dummy Cursor lazily.
Comment on attachment 48499 [details] Patch Using a function local static is fine. We have a macro we use for them called DEFINE_STATIC_LOCAL (I think it's mostly to work around a GCC but. This current implementation is also OK.
Comment on attachment 48499 [details] Patch There is a mistake in dummyCorsor returning a pointer while the return type is a reference to Cursor. I will update the patch using DEFINE_STATIC_LOCAL.
Created attachment 48542 [details] Patch Use DEFINE_STATIC_LOCAL.
Comment on attachment 48542 [details] Patch what is +#define LOG_TAG "WebCore" for?
Comment on attachment 48542 [details] Patch Clearing flags on attachment: 48542 Committed r54685: <http://trac.webkit.org/changeset/54685>
All reviewed patches have been landed. Closing bug.