WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34667
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
https://bugs.webkit.org/show_bug.cgi?id=34667
Summary
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
Yaar Schnitman
Reported
2010-02-05 15:59:14 PST
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
Attachments
Patch
(39.28 KB, patch)
2010-02-05 16:01 PST
,
Yaar Schnitman
no flags
Details
Formatted Diff
Diff
Ready for Review
(40.55 KB, patch)
2010-02-08 13:43 PST
,
Yaar Schnitman
no flags
Details
Formatted Diff
Diff
Updated patch
(40.54 KB, patch)
2010-02-08 13:53 PST
,
Yaar Schnitman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yaar Schnitman
Comment 1
2010-02-05 16:01:36 PST
Created
attachment 48272
[details]
Patch
Yaar Schnitman
Comment 2
2010-02-08 13:43:54 PST
Created
attachment 48363
[details]
Ready for Review
Yaar Schnitman
Comment 3
2010-02-08 13:53:45 PST
Created
attachment 48365
[details]
Updated patch
Yaar Schnitman
Comment 4
2010-02-08 13:57:12 PST
Comment on
attachment 48365
[details]
Updated patch Merged problems broke style & AWS...
Eric Seidel (no email)
Comment 5
2010-02-08 14:18:46 PST
Removing whitespace makes this patch needlessly large. Why change Database to DB? We tend to use full english words when possible in WebKit (obviously not HyperTextMarkupLanguage. :)
Yaar Schnitman
Comment 6
2010-02-08 14:41:01 PST
(In reply to
comment #5
)
> Removing whitespace makes this patch needlessly large.
Sorry about that, but I understand whitespace changes are ok in files I have other edits. They are very trivial though.
> Why change Database to DB? We tend to use full english words when possible in > WebKit (obviously not HyperTextMarkupLanguage. :)
I know, but the corresponding JS method this method enabled/disables is named IndexedDB, not IndexedDatabase. For code-generation and low maintenance reasons, the enabler and the JS method must correspond.
Adam Barth
Comment 7
2010-02-09 12:34:27 PST
Comment on
attachment 48365
[details]
Updated patch LGTM
WebKit Commit Bot
Comment 8
2010-02-10 02:36:47 PST
Comment on
attachment 48365
[details]
Updated patch Clearing flags on attachment: 48365 Committed
r54593
: <
http://trac.webkit.org/changeset/54593
>
WebKit Commit Bot
Comment 9
2010-02-10 02:36:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug