Bug 34667 - Simplified RuntimeEnabledFeatures and corresponding v8 generated code
Summary: Simplified RuntimeEnabledFeatures and corresponding v8 generated code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Yaar Schnitman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-05 15:59 PST by Yaar Schnitman
Modified: 2010-02-10 02:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (39.28 KB, patch)
2010-02-05 16:01 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
Ready for Review (40.55 KB, patch)
2010-02-08 13:43 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
Updated patch (40.54 KB, patch)
2010-02-08 13:53 PST, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2010-02-05 15:59:14 PST 
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
Comment 1 Yaar Schnitman 2010-02-05 16:01:36 PST 
Created attachment 48272 [details]
Patch
Comment 2 Yaar Schnitman 2010-02-08 13:43:54 PST 
Created attachment 48363 [details]
Ready for Review
Comment 3 Yaar Schnitman 2010-02-08 13:53:45 PST 
Created attachment 48365 [details]
Updated patch
Comment 4 Yaar Schnitman 2010-02-08 13:57:12 PST 
Comment on attachment 48365 [details]
Updated patch

Merged problems broke style & AWS...
Comment 5 Eric Seidel (no email) 2010-02-08 14:18:46 PST 
Removing whitespace makes this patch needlessly large.

Why change Database to DB?  We tend to use full english words when possible in WebKit (obviously not HyperTextMarkupLanguage. :)
Comment 6 Yaar Schnitman 2010-02-08 14:41:01 PST 
(In reply to comment #5)
> Removing whitespace makes this patch needlessly large.
Sorry about that, but I understand whitespace changes are ok in files I have other edits. They are very trivial though.
> Why change Database to DB?  We tend to use full english words when possible in
> WebKit (obviously not HyperTextMarkupLanguage. :)
I know, but the corresponding JS method this method enabled/disables is named IndexedDB, not IndexedDatabase. For code-generation and low maintenance reasons, the enabler and the JS method must correspond.
Comment 7 Adam Barth 2010-02-09 12:34:27 PST 
Comment on attachment 48365 [details]
Updated patch

LGTM
Comment 8 WebKit Commit Bot 2010-02-10 02:36:47 PST 
Comment on attachment 48365 [details]
Updated patch

Clearing flags on attachment: 48365

Committed r54593: <http://trac.webkit.org/changeset/54593>
Comment 9 WebKit Commit Bot 2010-02-10 02:36:55 PST 
All reviewed patches have been landed.  Closing bug.