RESOLVED FIXED 34664
[Chromium] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient 
https://bugs.webkit.org/show_bug.cgi?id=34664
Summary [Chromium] Rename autocomplete* to suggestions* to prepare for the refactorin...
James Hawkins
Reported 2010-02-05 14:50:07 PST
Patch will follow.
Attachments
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient (14.42 KB, patch)
2010-02-05 14:52 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try2] (14.96 KB, patch)
2010-02-05 14:59 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try3] (15.07 KB, patch)
2010-02-05 15:02 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try4] (15.16 KB, patch)
2010-02-05 15:10 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try5] (15.77 KB, patch)
2010-02-05 15:23 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6] (16.06 KB, patch)
2010-02-05 15:34 PST, James Hawkins 		fishd: review-
DetailsFormatted DiffDiff
Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7] (16.20 KB, patch)
2010-02-05 16:12 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-02-05 14:52:13 PST
Created attachment 48263 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient
WebKit Review Bot
Comment 2 2010-02-05 14:56:14 PST
Attachment 48263 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/240009
James Hawkins
Comment 3 2010-02-05 14:59:03 PST
Created attachment 48264 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try2] Forgot an occurrence of autocompletePopupDidHide.
James Hawkins
Comment 4 2010-02-05 15:02:32 PST
Created attachment 48265 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try3] Forgot to update the Changelog.
WebKit Review Bot
Comment 5 2010-02-05 15:03:31 PST
Attachment 48264 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/238371
WebKit Review Bot
Comment 6 2010-02-05 15:06:23 PST
Attachment 48265 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/240022
James Hawkins
Comment 7 2010-02-05 15:10:27 PST
Created attachment 48266 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try4] Add back suggestionsPopupDidHide.
WebKit Review Bot
Comment 8 2010-02-05 15:14:20 PST
Attachment 48266 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/240032
James Hawkins
Comment 9 2010-02-05 15:23:05 PST
Created attachment 48267 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try5] More build fixes...yikes.
WebKit Review Bot
Comment 10 2010-02-05 15:26:33 PST
Attachment 48267 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/238397
James Hawkins
Comment 11 2010-02-05 15:34:12 PST
Created attachment 48268 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6] Last one?
Darin Fisher (:fishd, Google)
Comment 12 2010-02-05 16:05:55 PST
Comment on attachment 48268 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6] > Index: WebKit/chromium/public/WebView.h > - // Hides the autofill popup if any are showing. > - virtual void hideAutofillPopup() = 0; > + // Hides the suggestions popup if any are showing. > + virtual void hideSuggestionsPopup() = 0; Please preserve the old API, and add a comment marking it DEPRECATED. You can just make your code call both functions for now. Then, once Chromium is updated to use the new function, you can come back and delete the deprecated one. Otherwise, LGTM.
James Hawkins
Comment 13 2010-02-05 16:12:10 PST
Created attachment 48274 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7] Adds back a deprecated hideAutofillPopup.
WebKit Commit Bot
Comment 14 2010-02-05 18:45:00 PST
Comment on attachment 48274 [details] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try7] Clearing flags on attachment: 48274 Committed r54458: <http://trac.webkit.org/changeset/54458>
WebKit Commit Bot
Comment 15 2010-02-05 18:45:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.