Bug 34659 - [chromium] webgl shouldn't hard code library search path
Summary: [chromium] webgl shouldn't hard code library search path
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Evan Martin
: 33032 (view as bug list)
Depends on:
Reported: 2010-02-05 13:29 PST by Evan Martin
Modified: 2010-02-09 11:07 PST (History)
5 users (show)

See Also:

Patch (2.58 KB, patch)
2010-02-05 13:30 PST, Evan Martin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-02-05 13:29:10 PST
[chromium] webgl shouldn't hard code library search path
Comment 1 Evan Martin 2010-02-05 13:30:08 PST
Created attachment 48253 [details]
Comment 2 Kenneth Russell 2010-02-05 13:47:40 PST
Looks good to me, but I'm not a WebKit reviewer. CC'ing Oliver Hunt (who is) and Chris Marrin.
Comment 3 Kenneth Russell 2010-02-05 13:48:58 PST
*** Bug 33032 has been marked as a duplicate of this bug. ***
Comment 4 Evan Martin 2010-02-05 13:50:02 PST
Wow, I have no recollection of filing that other bug, heh.
Comment 5 Kenneth Russell 2010-02-05 13:50:55 PST
(In reply to comment #4)
> Wow, I have no recollection of filing that other bug, heh.

Well, thanks for picking this up. I haven't had time to touch the Linux port recently.
Comment 6 WebKit Commit Bot 2010-02-08 19:05:42 PST
Comment on attachment 48253 [details]

Clearing flags on attachment: 48253

Committed r54524: <http://trac.webkit.org/changeset/54524>
Comment 7 WebKit Commit Bot 2010-02-08 19:05:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 David Levin 2010-02-08 21:21:31 PST
Just saw this get committed and noticed no reviewer line.

In the future, please leave the "Reviewed by NOBODY (OOPS)" line in the changelog. (This is also my mistake for not catching this when I gave you the r+ :S.)
Comment 9 Evan Martin 2010-02-09 11:07:30 PST
Gah, I'm sorry, I must've deleted the line in my ChangeLog accidentally.