Bug 34657 – Add additional parameter to create_rvct_stubs for setting the offset

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 48251 [details]
The patch

[Laszlo Gombos]

Change looks good to me, but I'd like to have more information on the motivation.

Which WebKit port intended to use this new feature ? 

I assume this work is for USE(JSVALUE32_64) - can you confirm ? 

Any reason for the following change:

> -my $file = $ARGV[0];

> +my $file;
> +$file = $ARGV[0];

[Gabor Loki]

Currently, only the JavaScriptCore/DerivedSources.pro uses the create_rvct_stubs script, but you did not change that pro file. Although the patch looks good, it is not complete. If you want to have this feature, please show an example how it will be used!

[Patrick R. Gansterer]

(In reply to comment #2)
> Change looks good to me, but I'd like to have more information on the
> motivation.
It's the first part for the WinCE JIT. Inline assabmler isn't supported and a additional file must be generated. The file should thenbe renamed to create_jit_stubs and have additional parameters for the "regex-prefix" (in the moment the RVCT([code])) and for skipping DEFINE_STUB_FUNCTION(int, op_eq_strings)

> Which WebKit port intended to use this new feature ?
WinCE

> I assume this work is for USE(JSVALUE32_64) - can you confirm ?
Of corse.

> Any reason for the following change:
No! ;-)

(In reply to comment #3)
> Currently, only the JavaScriptCore/DerivedSources.pro uses the
> create_rvct_stubs script, but you did not change that pro file. Although the
> patch looks good, it is not complete. If you want to have this feature, please
> show an example how it will be used!
I need it for the WinCE port where we don't have a buildsystem in the moment :-(

[Gabor Loki]

> > I assume this work is for USE(JSVALUE32_64) - can you confirm ?
> Of corse.
> ...
> I need it for the WinCE port where we don't have a buildsystem in the moment
> :-(

Ok, it is fine by me.

Btw, I would like to point on a problem of create_rvct_stubs. Currently the
Platform.h controls the usage of JSVALUE32_64. If Symbian and later WinCE
want to use JSVALUE32_64, their build systems will have to take over the
control JSVALUE32_64 from Platform.h (because of the generated stubs file).
Well, basically it is not a bug, it is an issue which has to be keep in mind.

[Laszlo Gombos]

Comment on attachment 48251 [details]
The patch

Thanks for the clarifications Patrick.

LGTM, r+.

[WebKit Commit Bot]

Comment on attachment 48251 [details]
The patch

Clearing flags on attachment: 48251

Committed r54781: <http://trac.webkit.org/changeset/54781>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.