Now the value of DownloadURL format is a string containing a list of values. So we need to change the chromium interface for it. In order not to break the existing stuff, I will first add the new member in this patch. Later on when chromium side change is committed, I will remove the obsolete member.
Created attachment 48244 [details] Proposed Patch
Comment on attachment 48244 [details] Proposed Patch > +++ b/WebCore/platform/chromium/ChromiumDataObject.cpp > @@ -38,6 +38,7 @@ void ChromiumDataObject::clear() > url = KURL(); > urlTitle = ""; > downloadURL = KURL(); > + downloadMetadata = ""; nit: should be "downloadMetaData" <-- cap "Data" > +++ b/WebKit/chromium/public/WebDragData.h > @@ -74,6 +74,8 @@ public: > > WEBKIT_API WebURL downloadURL() const; > WEBKIT_API void setDownloadURL(const WebURL&); > + WEBKIT_API WebString downloadMetadata() const; > + WEBKIT_API void setDownloadMetadata(const WebString&); same nit: should be named downloadMetaData and setDownloadMetaData otherwise, this LGTM
Actually, I take it back. http://en.wikipedia.org/wiki/Metadata seems to strongly favor the spelling you used. I had always thought of it as two words combined meta plus data, but I guess I was wrong.
Comment on attachment 48244 [details] Proposed Patch R=me (I'm also doing CQ+ since this shouldn't break the Chromium build.)
Comment on attachment 48244 [details] Proposed Patch Clearing flags on attachment: 48244 Committed r54469: <http://trac.webkit.org/changeset/54469>
All reviewed patches have been landed. Closing bug.