I have just downloaded a fresh tar of the source code. After extracting I executed update-webkit from cygwin. The result was a spew of error messages like these: cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/libxslt.lib': No such file or directory cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/pthreadVC2.lib': No such file or directory cp: cannot create regular file `/home/Leith\nBade/WebKit/WebKitLibraries/win/lib/SQLite3.lib': No such file or directory mv: cannot move `/tmp/webkitlibsFSMnc5X/WebKitAuxiliaryLibrary.headers' to `/home/Leith\nBade/WebKit/WebKitLibraries/win': No such file or directory Couldn't move WebKitAuxiliaryLibrary.headers to /home/Leith Bade/WebKit/WebKitLibraries/win. The WebKitAuxiliaryLibrary has been sucessfully installed in /home/Leith Bade/WebKit/WebKitLibraries/win It would appear update-webkit-auxiliary-libs some how screws up the path to the WebKit folder "/home/Leith Bade/WebKit" and replaces that space in "Leith Bade" with "Leith/nBade" (newline). Also the other bug worth mentioning here is that the message "The WebKitAuxiliaryLibrary has been sucessfully installed in" is clearly misleading as it does not check if the unzip works.
It would appear that both environment variables WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR are set incorrectly. WEBKITOUTPUTDIR was C:\home\cygwin\Leith which does not exist ("C:\home\cygwin\Leith Bade" does).
Don't suppose this is related to the change for #31228 ?
I have traced it down to whatever sets the WEBKITLIBRARIESDIR environment variable in the registry. It seems to replace the space with a newline wen it sets the reg key.
OK it seems putting quotes around $WEBKITLIBRARIESDIR fixes the problem. eg cygpath -u "$WEBKITLIBRARIESDIR" otherwise cygpath treats the space as seperating two different paths to convert hence why it puts each respective path on a new line in it's output.
Created attachment 48301 [details] Proposed patch.
I forgot to put a fix in for the "The WebKitAuxiliaryLibrary has been sucessfully installed in" bug. This might need to go under a different bug #? (I am not familiar enough with Perl to confidently make that change)
Also in order to support Visual Studio, there needs to be a trailing '\' in the environment variable.
Comment on attachment 48301 [details] Proposed patch. Now we can handle paths with spaces, but not ones with single quotes. A step in the right direction, I guess.
(In reply to comment #8) > (From update of attachment 48301 [details]) > Now we can handle paths with spaces, but not ones with single quotes. A step in > the right direction, I guess. Yeah I suppose some people might have a `'` in their user name. Ag. "Leith's Computer" or something like that. Double quotes could fix this... As `"` is an illegal filename char in Windows. I note that in webkitdirs.pm there is an inconsistent use of cygpath. Some use `'`, some use `"` and some even do no quotes at all... Should the entire file be cleaned up to use only `"`?
Comment on attachment 48301 [details] Proposed patch. Clearing flags on attachment: 48301 Committed r54477: <http://trac.webkit.org/changeset/54477>
All reviewed patches have been landed. Closing bug.