Bug 34625 - editing/execCommand/indent-paragraphs.html is missing pixel test results
Summary: editing/execCommand/indent-paragraphs.html is missing pixel test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 17:29 PST by Tony Chang
Modified: 2010-02-08 03:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (62.82 KB, patch)
2010-02-04 17:32 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (8.90 KB, patch)
2010-02-07 18:21 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-02-04 17:29:51 PST
editing/execCommand/indent-paragraphs.html is missing pixel test results
Comment 1 Tony Chang 2010-02-04 17:32:02 PST
Created attachment 48184 [details]
Patch
Comment 2 Darin Adler 2010-02-05 06:58:54 PST
But since this test puts the markup into the page, it probably should have just been a dumpAsText test in the first place.
Comment 3 WebKit Commit Bot 2010-02-05 08:34:09 PST
Comment on attachment 48184 [details]
Patch

Rejecting patch 48184 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
RA layer request failed: PROPFIND request failed on '/repository/webkit/trunk': PROPFIND of '/repository/webkit/trunk': timed out waiting for server (http://svn.webkit.org) at /usr/local/git/libexec/git-core/git-svn line 557


Full output: http://webkit-commit-queue.appspot.com/results/238136
Comment 4 Eric Seidel (no email) 2010-02-05 12:03:10 PST
Attachment 48184 [details] was posted by a committer and has review+, assigning to Tony Chang for commit.
Comment 5 Tony Chang 2010-02-07 18:21:29 PST
Created attachment 48311 [details]
Patch
Comment 6 Tony Chang 2010-02-07 18:22:07 PST
(In reply to comment #2)
> But since this test puts the markup into the page, it probably should have just
> been a dumpAsText test in the first place.

Yes, that would be better.  I've switched it to a dumpAsText() test.
Comment 7 WebKit Commit Bot 2010-02-08 03:04:43 PST
Comment on attachment 48311 [details]
Patch

Clearing flags on attachment: 48311

Committed r54478: <http://trac.webkit.org/changeset/54478>
Comment 8 WebKit Commit Bot 2010-02-08 03:04:57 PST
All reviewed patches have been landed.  Closing bug.