WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34618
Make MathExtras.h compatible with <cmath>
https://bugs.webkit.org/show_bug.cgi?id=34618
Summary
Make MathExtras.h compatible with <cmath>
Darin Adler
Reported
2010-02-04 14:23:04 PST
Make MathExtras.h compatible with <cmath>
Attachments
Patch
(1.74 KB, patch)
2010-02-04 14:25 PST
,
Darin Adler
levin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2010-02-04 14:25:59 PST
Created
attachment 48171
[details]
Patch
WebKit Review Bot
Comment 2
2010-02-04 14:29:48 PST
Attachment 48171
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/MathExtras.h:189: Use 'using namespace std;' instead of 'using std::isfinite;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:190: Use 'using namespace std;' instead of 'using std::isinf;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:191: Use 'using namespace std;' instead of 'using std::isnan;'. [build/using_std] [4] JavaScriptCore/wtf/MathExtras.h:192: Use 'using namespace std;' instead of 'using std::signbit;'. [build/using_std] [4] Total errors found: 4 If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3
2010-02-04 17:01:58 PST
Committed
r54388
: <
http://trac.webkit.org/changeset/54388
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug