Bug 34618 - Make MathExtras.h compatible with <cmath>
Summary: Make MathExtras.h compatible with <cmath>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 14:23 PST by Darin Adler
Modified: 2010-02-04 17:01 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2010-02-04 14:25 PST, Darin Adler 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-02-04 14:23:04 PST 
Make MathExtras.h compatible with <cmath>
Comment 1 Darin Adler 2010-02-04 14:25:59 PST 
Created attachment 48171 [details]
Patch
Comment 2 WebKit Review Bot 2010-02-04 14:29:48 PST 
Attachment 48171 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/MathExtras.h:189:  Use 'using namespace std;' instead of 'using std::isfinite;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:190:  Use 'using namespace std;' instead of 'using std::isinf;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:191:  Use 'using namespace std;' instead of 'using std::isnan;'.  [build/using_std] [4]
JavaScriptCore/wtf/MathExtras.h:192:  Use 'using namespace std;' instead of 'using std::signbit;'.  [build/using_std] [4]
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2010-02-04 17:01:58 PST 
Committed r54388: <http://trac.webkit.org/changeset/54388>