When MinGW compiler is used to compile Netscape Plugins on Windows XP with Qt, npapi.h tries to include windows.h. This is because in npapi.h ifdef clause for __SYMBIAN32__ does not undefine XP_WIN and npapi.h eventually ends up trying to include windows.h eventhough user is building for Symbian. This problem is reproducible with nightly build -r54342 Here is the error seen while trying to compile a sample Netscape Plug-in: make -s -r -f "\EPOC32\BUILD\cwrt\plugins\s60\SampleNPQtPlugin\SAMPLENPQTPLUGIN_0XE0AE5E3D\WINSCW\SAMPLENPQTPLUGIN_0XE0AE5E3D.WINSCW" UDEB samplenpqtplugin.cpp npapi.h:116: the file 'windows.h' cannot be opened Proposed Solution: add #undef XP_WIN after #define XP_SYMBIAN 1 in the ifdef clause for __SYMBIAN32__
Abhinav, any update on this ?
Created attachment 52639 [details] This patch checks for Symbian flag definition before defining XP_WIN flag and takes care of the issue.
Created attachment 52653 [details] This is a new patch which has been tested for both winscw and armv5
Comment on attachment 52653 [details] This is a new patch which has been tested for both winscw and armv5 lgtm, thanks. This seems to be a regression after r49987.
Comment on attachment 52653 [details] This is a new patch which has been tested for both winscw and armv5 Clearing flags on attachment: 52653 Committed r57170: <http://trac.webkit.org/changeset/57170>
All reviewed patches have been landed. Closing bug.
Revision r57170 cherry-picked into qtwebkit-2.0 with commit b246edd8056941a91f1ceec2fcd45850d647ef34
*** Bug 39708 has been marked as a duplicate of this bug. ***
Revision r57170 cherry-picked into qtwebkit-4.6 with aa3f786bdba4dc153620ae7f98e4b0e41770d1d1