Bug 34613 - [WinCairo] Properly Handle Margin Settings For Plugins
Summary: [WinCairo] Properly Handle Margin Settings For Plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 13:22 PST by Brent Fulgham
Modified: 2010-02-04 14:11 PST (History)
0 users

See Also:


Attachments
Adjusts global context used by plugin printing to account for margin settings. (2.54 KB, patch)
2010-02-04 13:29 PST, Brent Fulgham
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2010-02-04 13:22:59 PST
The changes made in Bug 34545 corrected margin handling for standard text and graphics, but did not address the handling of plugins during print operations.  The attached patch correctly adjusts the World Context used during the 'paintContents' call so that Plugins are rendered in the proper location.
Comment 1 Brent Fulgham 2010-02-04 13:29:47 PST
Created attachment 48164 [details]
Adjusts global context used by plugin printing to account for margin settings.
Comment 2 Adam Roben (:aroben) 2010-02-04 13:33:08 PST
Comment on attachment 48164 [details]
Adjusts global context used by plugin printing to account for margin settings.

r=me
Comment 3 Brent Fulgham 2010-02-04 14:11:26 PST
Landed in https://trac.webkit.org/changeset/54370.