Bug 34600 - [BREWMP] Port PlatformMouseEvent
Summary: [BREWMP] Port PlatformMouseEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-02-04 09:41 PST by Kwang Yul Seo
Modified: 2010-02-09 19:45 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2010-02-04 09:46 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2010-02-04 09:48 PST, Kwang Yul Seo
levin: review-
Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2010-02-05 20:25 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2010-02-05 20:43 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-02-04 09:41:07 PST
Port PlatformMouseEvent to BREWMP.
Comment 1 Kwang Yul Seo 2010-02-04 09:46:57 PST
Created attachment 48150 [details]
Patch

Retrieve the event type, position, key modifiers, time stamp and click count from AEEEvent.
Comment 2 Kwang Yul Seo 2010-02-04 09:48:47 PST
Created attachment 48151 [details]
Patch

Sort header files alphabetically.
Comment 3 WebKit Review Bot 2010-02-04 09:49:15 PST
Attachment 48150 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/brew/PlatformMouseEventBrew.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Levin 2010-02-05 09:51:59 PST
Comment on attachment 48151 [details]
Patch

> Index: WebCore/platform/PlatformMouseEvent.h
> @@ -55,6 +55,12 @@ class wxMouseEvent;
>  class BMessage;
>  #endif
>  
> +#if PLATFORM(BREWMP)
> +typedef unsigned short    uint16;
> +typedef unsigned long int uint32;
> +#define AEEEvent uint16

Why doesn't this use a typedef (instead of a define)?

> +#if PLATFORM(BREWMP)
> +        PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwParam);

The param name event is not needed here.
Comment 5 Kwang Yul Seo 2010-02-05 20:20:54 PST
(In reply to comment #4)
> (From update of attachment 48151 [details])
> > Index: WebCore/platform/PlatformMouseEvent.h
> > @@ -55,6 +55,12 @@ class wxMouseEvent;
> >  class BMessage;
> >  #endif
> >  
> > +#if PLATFORM(BREWMP)
> > +typedef unsigned short    uint16;
> > +typedef unsigned long int uint32;
> > +#define AEEEvent uint16
> 
> Why doesn't this use a typedef (instead of a define)?

Because AEEEvent.h defines AEEEvent to uint16.

#define AEEEvent  uint16

> 
> > +#if PLATFORM(BREWMP)
> > +        PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwParam);
> 
> The param name event is not needed here.

Okay.
Comment 6 Kwang Yul Seo 2010-02-05 20:25:22 PST
Created attachment 48280 [details]
Patch

Remove the param name event from PlatformMouseEvent constructor declaration.
Comment 7 WebKit Review Bot 2010-02-05 20:29:46 PST
Attachment 48280 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/brew/PlatformMouseEventBrew.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Kwang Yul Seo 2010-02-05 20:43:35 PST
Created attachment 48282 [details]
Patch

Remove style errors.
Comment 9 WebKit Review Bot 2010-02-05 21:50:27 PST
Attachment 48282 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/238598
Comment 10 Kwang Yul Seo 2010-02-05 21:52:36 PST
(In reply to comment #9)
> Attachment 48282 [details] did not build on chromium:
> Build output: http://webkit-commit-queue.appspot.com/results/238598

It seems the chromium build error is unrelated to this patch.
Comment 11 Adam Barth 2010-02-09 09:35:09 PST
Comment on attachment 48282 [details]
Patch

Sorry about the Chromium build error.  The bot was having some trouble.  I'm not an expert on platform mouse events, but this patch looks reasonable to me.
Comment 12 WebKit Commit Bot 2010-02-09 19:45:26 PST
Comment on attachment 48282 [details]
Patch

Clearing flags on attachment: 48282

Committed r54583: <http://trac.webkit.org/changeset/54583>
Comment 13 WebKit Commit Bot 2010-02-09 19:45:35 PST
All reviewed patches have been landed.  Closing bug.