Bug 34597 - [Qt] Build break in QtWebkit on Symbian
Summary: [Qt] Build break in QtWebkit on Symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 08:57 PST by Siddharth Mathur
Modified: 2010-02-05 06:10 PST (History)
2 users (show)

See Also:


Attachments
Fixing erroneous removal of OS(SYMBIAN) (978 bytes, patch)
2010-02-04 15:27 PST, Siddharth Mathur
ariya.hidayat: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2010-02-04 08:57:45 PST
r53955 causes build break in QtWebkit/Symbian. 

Notice the change from  OS(SYMBIAN) to PLATFORM(SYMBIAN). It seems it is unrelated to the GTK2-related theme of Bug 18831 : 
https://bugs.webkit.org/attachment.cgi?id=47166&action=diff#a/WebCore/plugins/PluginView.h_sec3



Error message is for WebCore\plugins\symbian\PluginViewSymbian.cpp

Error: #20: identifier "setNPWindowIfNeeded" is undefined
	setNPWindowIfNeeded();
Comment 1 Siddharth Mathur 2010-02-04 15:27:48 PST
Created attachment 48177 [details]
Fixing erroneous removal of OS(SYMBIAN)

Fixing erroneous removal of OS(SYMBIAN).
Comment 2 Ariya Hidayat 2010-02-04 16:43:24 PST
Comment on attachment 48177 [details]
Fixing erroneous removal of OS(SYMBIAN)

LGTM.
Comment 3 Simon Hausmann 2010-02-05 02:28:52 PST
Comment on attachment 48177 [details]
Fixing erroneous removal of OS(SYMBIAN)

I agree that this is a no-brainer :)

> +        No new tests. (OOPS!)

But please remove this line when landing :)
Comment 4 Simon Hausmann 2010-02-05 06:10:38 PST
Committed r54422: <http://trac.webkit.org/changeset/54422>