This was added in Bug 33840.
Created attachment 48131 [details] Patch v1
Attachment 48131 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 48131 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > underscores in your identifier names. [readability/naming] [4] > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > [readability/null] [5] > Total errors found: 2 Looks like these files should be in the exception list of our style checker?
Comment on attachment 48131 [details] Patch v1 I was going to say the function name lacked a 'get' somewhere, to be consistent, but I see we have previous cases of that; we might want to review all of them while exposing. Thanks for the patch!
(In reply to comment #3) > (In reply to comment #2) > > Attachment 48131 [details] [details] did not pass style-queue: > > > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > > underscores in your identifier names. [readability/naming] [4] > > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > > [readability/null] [5] > > Total errors found: 2 > > Looks like these files should be in the exception list of our style checker? Indeed. Rules here should be the same as for WebKit/gtk/
Attachment 48131 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Comment on attachment 48131 [details] Patch v1 Clearing flags on attachment: 48131 Committed r54461: <http://trac.webkit.org/changeset/54461>
All reviewed patches have been landed. Closing bug.