Bug 34563 - websocket/tests/close-on-unload.html failed on Mac Tiger
Summary: websocket/tests/close-on-unload.html failed on Mac Tiger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.3
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 23:23 PST by Fumitoshi Ukai
Modified: 2010-02-04 21:59 PST (History)
0 users

See Also:


Attachments
Patch (2.21 KB, patch)
2010-02-04 01:18 PST, Fumitoshi Ukai
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2010-02-03 23:23:06 PST
since r54319, websocket/tests/close-on-unload.html failed on Mac Tiger.
This is because python is old on the platform (no set() available)

http://build.webkit.org/results/Tiger%20Intel%20Release/r54323%20(8478)/pywebsocket_log.txt
Comment 1 Fumitoshi Ukai 2010-02-04 01:18:58 PST
Created attachment 48115 [details]
Patch
Comment 2 Shinichiro Hamaji 2010-02-04 04:07:31 PST
Comment on attachment 48115 [details]
Patch

Looks good except for a few nitpicks.

> -connections = set()
> +connections = {}

I'd comment why we don't use set() here so people don't make this fail again.

> +        for ws in connections.keys():

I slightly prefer iterkeys() but it's OK as is.
Comment 3 Fumitoshi Ukai 2010-02-04 21:59:57 PST
Committed r54404: <http://trac.webkit.org/changeset/54404>