Bug 34559 - [Qt] Unnecessary QBrush construction for doing a solid fill
Summary: [Qt] Unnecessary QBrush construction for doing a solid fill
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-02-03 21:28 PST by Ariya Hidayat
Modified: 2010-02-04 09:44 PST (History)
0 users

See Also:

Attachments
Patch (613 bytes, patch)
2010-02-03 21:28 PST, Ariya Hidayat 		no flags Details | Formatted Diff | Diff
Patch (1.29 KB, patch)
2010-02-03 21:38 PST, Ariya Hidayat 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-02-03 21:28:01 PST 
Created attachment 48097 [details]
Patch

Setting the fill to a solid color forces a construction of QBrush (which is expensive).
Comment 1 Ariya Hidayat 2010-02-03 21:38:34 PST 
Created attachment 48101 [details]
Patch
Comment 2 Simon Hausmann 2010-02-04 02:35:17 PST 
Comment on attachment 48101 [details]
Patch

Good idea! :)
Comment 3 Ariya Hidayat 2010-02-04 09:44:06 PST 
Manually committed r54347: in http://trac.webkit.org/changeset/54347