[V8] Move Element custom methods into generic bindings so that they can be shared.
Created attachment 48091 [details] Patch
Attachment 48091 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/generic/BindingElement.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 48092 [details] Patch--fixes style violation.
Created attachment 48094 [details] Patch--updates WebCore.gypi
Comment on attachment 48094 [details] Patch--updates WebCore.gypi In general, this looks good, but I do think V8BindingElement.h is too verbose, as you mentioned in email. We should find a place do do that as a typedef. Also, we don't need V8Binding::Element since the generic bindings don't need to call back to the V8 bindings.
Created attachment 48189 [details] Patch--implements review feedback. Thanks for your feedback. I have made V8BindingElement a typedef in V8Binding.h and nixed V8BindingElement.h, V8Binding::Element.
Comment on attachment 48189 [details] Patch--implements review feedback. fantabulous!
Comment on attachment 48189 [details] Patch--implements review feedback. Clearing flags on attachment: 48189 Committed r54527: <http://trac.webkit.org/changeset/54527>
All reviewed patches have been landed. Closing bug.