Bug 34554 - [V8] Move Element custom methods into generic bindings
Summary: [V8] Move Element custom methods into generic bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 19:40 PST by Dominic Cooney
Modified: 2010-02-08 22:49 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.88 KB, patch)
2010-02-03 19:46 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff
Patch--fixes style violation. (11.88 KB, patch)
2010-02-03 19:53 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff
Patch--updates WebCore.gypi (12.92 KB, patch)
2010-02-03 20:41 PST, Dominic Cooney
abarth: review-
Details | Formatted Diff | Diff
Patch--implements review feedback. (9.97 KB, patch)
2010-02-04 18:06 PST, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2010-02-03 19:40:22 PST
[V8] Move Element custom methods into generic bindings so that they can be shared.
Comment 1 Dominic Cooney 2010-02-03 19:46:33 PST
Created attachment 48091 [details]
Patch
Comment 2 WebKit Review Bot 2010-02-03 19:49:54 PST
Attachment 48091 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/generic/BindingElement.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dominic Cooney 2010-02-03 19:53:47 PST
Created attachment 48092 [details]
Patch--fixes style violation.
Comment 4 Dominic Cooney 2010-02-03 20:41:58 PST
Created attachment 48094 [details]
Patch--updates WebCore.gypi
Comment 5 Adam Barth 2010-02-04 02:32:51 PST
Comment on attachment 48094 [details]
Patch--updates WebCore.gypi

In general, this looks good, but I do think V8BindingElement.h is too verbose, as you mentioned in email.  We should find a place do do that as a typedef.

Also, we don't need V8Binding::Element since the generic bindings don't need to call back to the V8 bindings.
Comment 6 Dominic Cooney 2010-02-04 18:06:50 PST
Created attachment 48189 [details]
Patch--implements review feedback.

Thanks for your feedback.

I have made V8BindingElement a typedef in V8Binding.h and nixed V8BindingElement.h, V8Binding::Element.
Comment 7 Adam Barth 2010-02-08 15:39:28 PST
Comment on attachment 48189 [details]
Patch--implements review feedback.

fantabulous!
Comment 8 WebKit Commit Bot 2010-02-08 22:48:54 PST
Comment on attachment 48189 [details]
Patch--implements review feedback.

Clearing flags on attachment: 48189

Committed r54527: <http://trac.webkit.org/changeset/54527>
Comment 9 WebKit Commit Bot 2010-02-08 22:49:00 PST
All reviewed patches have been landed.  Closing bug.