Bug 34551 - WorkerContext.close() does not work in the chromium port
Summary: WorkerContext.close() does not work in the chromium port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 18:22 PST by Andrew Wilson
Modified: 2010-02-04 15:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2010-02-04 15:09 PST, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2010-02-03 18:22:37 PST
We do not shutdown the Worker thread in the chromium port when the thread calls close(). 

This means that code like this:

var worker = new Worker("worker.js");

worker.js:
close();


Will leave the thread running until the parent window shuts down. There's code in Chromium to prevent further messages from being to/from the closing thread, but the thread itself still sits there.
Comment 1 Andrew Wilson 2010-02-04 15:09:39 PST
Created attachment 48172 [details]
Patch
Comment 2 WebKit Commit Bot 2010-02-04 15:43:30 PST
Comment on attachment 48172 [details]
Patch

Clearing flags on attachment: 48172

Committed r54380: <http://trac.webkit.org/changeset/54380>
Comment 3 WebKit Commit Bot 2010-02-04 15:43:36 PST
All reviewed patches have been landed.  Closing bug.