Bug 34528 - WebCore/platform/graphics/GlyphPageTreeNode.cpp needs to #include stdio.h in debug build
Summary: WebCore/platform/graphics/GlyphPageTreeNode.cpp needs to #include stdio.h in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 07:26 PST by Stephan Aßmus
Modified: 2010-02-22 16:55 PST (History)
2 users (show)

See Also:

Attachments
Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. (441 bytes, patch)
2010-02-03 07:28 PST, Stephan Aßmus 		darin: review-
Details | Formatted Diff | Diff
Revised patch with changelog. (1.07 KB, patch)
2010-02-18 01:42 PST, Stephan Aßmus 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Aßmus 2010-02-03 07:26:22 PST 
As in summary.
Comment 1 Stephan Aßmus 2010-02-03 07:28:31 PST 
Created attachment 48026 [details]
Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined.
Comment 2 Darin Adler 2010-02-03 10:00:45 PST 
Comment on attachment 48026 [details]
Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined.

Thanks.

This is fine but:

1) No real need to put the ifdef around the include. An unconditional include of <stdio.h> would be fine.

2) Need a change log.

review- because of the lack of change log
Comment 3 Stephan Aßmus 2010-02-18 01:42:31 PST 
Created attachment 48985 [details]
Revised patch with changelog.

Replaces previous patch and fixes the issues pointed out.
Comment 4 Eric Seidel (no email) 2010-02-22 13:05:14 PST 
What platform were you building on that saw this error?
Comment 5 Stephan Aßmus 2010-02-22 13:12:08 PST 
I was using Haiku. We use a jam based build system. It's setup such that when NDEBUG is exported in the environment, it passes -DNDEBUG=1 to CC and C++ flags.

BTW. Using the Haiku WebKit browser to post this comment! :-D
Comment 6 WebKit Commit Bot 2010-02-22 16:55:40 PST 
Comment on attachment 48985 [details]
Revised patch with changelog.

Clearing flags on attachment: 48985

Committed r55113: <http://trac.webkit.org/changeset/55113>
Comment 7 WebKit Commit Bot 2010-02-22 16:55:45 PST 
All reviewed patches have been landed.  Closing bug.