RESOLVED FIXED 34528
WebCore/platform/graphics/GlyphPageTreeNode.cpp needs to #include stdio.h in debug build 
https://bugs.webkit.org/show_bug.cgi?id=34528
Summary WebCore/platform/graphics/GlyphPageTreeNode.cpp needs to #include stdio.h in ...
Stephan Aßmus
Reported 2010-02-03 07:26:22 PST
As in summary.
Attachments
Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. (441 bytes, patch)
2010-02-03 07:28 PST, Stephan Aßmus 		darin: review-
DetailsFormatted DiffDiff
Revised patch with changelog. (1.07 KB, patch)
2010-02-18 01:42 PST, Stephan Aßmus 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Aßmus
Comment 1 2010-02-03 07:28:31 PST
Created attachment 48026 [details] Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined.
Darin Adler
Comment 2 2010-02-03 10:00:45 PST
Comment on attachment 48026 [details] Include <stdio.h> when compiling without NDEBUG #define. The code later uses printf() when NDEBUG is not defined. Thanks. This is fine but: 1) No real need to put the ifdef around the include. An unconditional include of <stdio.h> would be fine. 2) Need a change log. review- because of the lack of change log
Stephan Aßmus
Comment 3 2010-02-18 01:42:31 PST
Created attachment 48985 [details] Revised patch with changelog. Replaces previous patch and fixes the issues pointed out.
Eric Seidel (no email)
Comment 4 2010-02-22 13:05:14 PST
What platform were you building on that saw this error?
Stephan Aßmus
Comment 5 2010-02-22 13:12:08 PST
I was using Haiku. We use a jam based build system. It's setup such that when NDEBUG is exported in the environment, it passes -DNDEBUG=1 to CC and C++ flags. BTW. Using the Haiku WebKit browser to post this comment! :-D
WebKit Commit Bot
Comment 6 2010-02-22 16:55:40 PST
Comment on attachment 48985 [details] Revised patch with changelog. Clearing flags on attachment: 48985 Committed r55113: <http://trac.webkit.org/changeset/55113>
WebKit Commit Bot
Comment 7 2010-02-22 16:55:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.