WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34516
[BREWMP] Port KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=34516
Summary
[BREWMP] Port KURL::fileSystemPath
Kwang Yul Seo
Reported
2010-02-03 00:24:17 PST
Convert a file URL to a file path.
Attachments
Port KURL::fileSystemPath
(2.05 KB, patch)
2010-02-03 01:26 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
Port KURL::fileSystemPath
(2.32 KB, patch)
2010-02-04 09:35 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-02-03 01:26:47 PST
Created
attachment 48004
[details]
Port KURL::fileSystemPath
Eric Seidel (no email)
Comment 2
2010-02-03 16:20:26 PST
Comment on
attachment 48004
[details]
Port KURL::fileSystemPath Why is CString.h include needed? Are you sure this is correct? Does the brew port really never use root-relative file urls?
Kwang Yul Seo
Comment 3
2010-02-04 09:28:13 PST
(In reply to
comment #2
)
> (From update of
attachment 48004
[details]
) > Why is CString.h include needed? > > Are you sure this is correct? Does the brew port really never use > root-relative file urls?
This is intentional. This follows the behavior of IWeb, BREW's HTTP engine which opens files in BREW's application-relative file namespace.
Kwang Yul Seo
Comment 4
2010-02-04 09:35:43 PST
Created
attachment 48149
[details]
Port KURL::fileSystemPath Add more comments to explain why we use application relative paths.
Eric Seidel (no email)
Comment 5
2010-02-08 15:49:33 PST
Comment on
attachment 48149
[details]
Port KURL::fileSystemPath I'm not sure how this will affect loading resources that WebCore depends on from disk. Like cursor images or CSS files, but OK.
WebKit Commit Bot
Comment 6
2010-02-09 02:24:18 PST
Comment on
attachment 48149
[details]
Port KURL::fileSystemPath Clearing flags on attachment: 48149 Committed
r54542
: <
http://trac.webkit.org/changeset/54542
>
WebKit Commit Bot
Comment 7
2010-02-09 02:24:24 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug