Bug 34516 - [BREWMP] Port KURL::fileSystemPath
Summary: [BREWMP] Port KURL::fileSystemPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-02-03 00:24 PST by Kwang Yul Seo
Modified: 2010-02-09 02:24 PST (History)
1 user (show)

See Also:

Attachments
Port KURL::fileSystemPath (2.05 KB, patch)
2010-02-03 01:26 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Port KURL::fileSystemPath (2.32 KB, patch)
2010-02-04 09:35 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-02-03 00:24:17 PST 
Convert a file URL to a file path.
Comment 1 Kwang Yul Seo 2010-02-03 01:26:47 PST 
Created attachment 48004 [details]
Port KURL::fileSystemPath
Comment 2 Eric Seidel (no email) 2010-02-03 16:20:26 PST 
Comment on attachment 48004 [details]
Port KURL::fileSystemPath

Why is CString.h include needed?

Are you sure this is correct?  Does the brew port really never use root-relative file urls?
Comment 3 Kwang Yul Seo 2010-02-04 09:28:13 PST 
(In reply to comment #2)
> (From update of attachment 48004 [details])
> Why is CString.h include needed?
> 
> Are you sure this is correct?  Does the brew port really never use
> root-relative file urls?

This is intentional. This follows the behavior of IWeb, BREW's HTTP engine which opens files in BREW's application-relative file namespace.
Comment 4 Kwang Yul Seo 2010-02-04 09:35:43 PST 
Created attachment 48149 [details]
Port KURL::fileSystemPath

Add more comments to explain why we use application relative paths.
Comment 5 Eric Seidel (no email) 2010-02-08 15:49:33 PST 
Comment on attachment 48149 [details]
Port KURL::fileSystemPath

I'm not sure how this will affect loading resources that WebCore depends on from disk.  Like cursor images or CSS files, but OK.
Comment 6 WebKit Commit Bot 2010-02-09 02:24:18 PST 
Comment on attachment 48149 [details]
Port KURL::fileSystemPath

Clearing flags on attachment: 48149

Committed r54542: <http://trac.webkit.org/changeset/54542>
Comment 7 WebKit Commit Bot 2010-02-09 02:24:24 PST 
All reviewed patches have been landed.  Closing bug.