Bug 34514 - [BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
Summary: [BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-02-02 23:06 PST by Kwang Yul Seo
Modified: 2010-02-03 18:53 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.16 KB, patch)
2010-02-02 23:09 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-02-02 23:06:45 PST
WTF_PLATFORM_BREWMP_SIMULATOR is needed to make distinction between BREWMP and BREWMP simulator.
Comment 1 Kwang Yul Seo 2010-02-02 23:09:16 PST
Created attachment 47997 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-03 16:23:20 PST
Comment on attachment 47997 [details]
Patch

Do you compile the binary differently to run inside the simulator?  I guess so.
Comment 3 WebKit Commit Bot 2010-02-03 18:49:36 PST
Comment on attachment 47997 [details]
Patch

Clearing flags on attachment: 47997

Committed r54320: <http://trac.webkit.org/changeset/54320>
Comment 4 WebKit Commit Bot 2010-02-03 18:49:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Kwang Yul Seo 2010-02-03 18:53:10 PST
(In reply to comment #2)
> (From update of attachment 47997 [details])
> Do you compile the binary differently to run inside the simulator?  I guess so.

Yes. there is some simulator specific code. For example, IDebugger interface is not available for simulator, so I use OS(WINDOWS) code to retrieve the stack base address in simulator.