Bug 34510 - 54113 causes crashes with -webkit-gradient and border-bottom
Summary: 54113 causes crashes with -webkit-gradient and border-bottom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL: http://www.bing.com/reference/semhtml...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 18:39 PST by James Robinson
Modified: 2010-02-02 21:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2010-02-02 19:42 PST, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-02-02 18:39:27 PST 
The following:

<!DOCTYPE html> 
<div style="border-bottom:1px solid; background:-webkit-gradient(linear,0% 100%, 0% 100%, from(red),to(blue))"> 
</div>

makes WebKit asplode after r54113.  This structure is used on http://www.bing.com/reference/semhtml/Navagio (and probably other pages as well).
Comment 1 James Robinson 2010-02-02 19:42:28 PST 
Created attachment 47988 [details]
Patch
Comment 2 Dmitry Titov 2010-02-02 20:09:50 PST 
Comment on attachment 47988 [details]
Patch

Looks good.
Comment 3 WebKit Commit Bot 2010-02-02 21:22:19 PST 
Comment on attachment 47988 [details]
Patch

Clearing flags on attachment: 47988

Committed r54272: <http://trac.webkit.org/changeset/54272>
Comment 4 WebKit Commit Bot 2010-02-02 21:22:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 James Robinson 2010-02-02 21:25:36 PST 
The commit message is pretty borked:
http://trac.webkit.org/changeset/54272

I think it's because the diff for WebCore/ChangeLog looks like this:


-2010-02-02  Fumitoshi Ukai  <ukai@chromium.org>
+2010-02-02  James Robinson  <jamesr@chromium.org>
 
+        Reviewed by NOBODY (OOPS!).
+
+        Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash
+        https://bugs.webkit.org/show_bug.cgi?id=34510
+
+        * fast/gradients/crash-on-1px-border.html: Added.
+
+2010-02-02  Fumitoshi Ukai  <ukai@chromium.org> 

where it should have been just:

+2010-02-02  James Robinson  <jamesr@chromium.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        Test that the combination of border-bottom:1px; and -webkit-gradient(linear) doesn't crash
+        https://bugs.webkit.org/show_bug.cgi?id=34510
+
+        * fast/gradients/crash-on-1px-border.html: Added.

I guess git got a bit confused when generating the diff?
Comment 6 James Robinson 2010-02-02 21:30:43 PST 
My apologies, I meant LayoutTests/ChangeLog.  The ChangeLog is now slightly out of order as well.