34509 – Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin

RESOLVED FIXED 34509

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin

https://bugs.webkit.org/show_bug.cgi?id=34509

Summary Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin

Yaar Schnitman

Reported 2010-02-02 18:33:50 PST

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin

Attachments
Patch (34.57 KB, patch) 2010-02-02 18:34 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch 2 (34.57 KB, patch) 2010-02-02 18:38 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (34.65 KB, patch) 2010-02-03 16:58 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Patch (34.71 KB, patch) 2010-02-04 15:40 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Yaar Schnitman

Comment 1 2010-02-02 18:34:26 PST

Created attachment 47985 [details] Patch

Yaar Schnitman

Comment 2 2010-02-02 18:38:09 PST

Created attachment 47986 [details] Patch 2

WebKit Review Bot

Comment 3 2010-02-02 18:39:24 PST

Attachment 47985 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/tests/TransparencyWinTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:38: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 4 2010-02-02 18:39:56 PST

Attachment 47986 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/tests/TransparencyWinTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:38: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Fisher (:fishd, Google)

Comment 5 2010-02-02 20:59:50 PST

Comment on attachment 47986 [details] Patch 2 > +2010-02-02 Yaar Schnitman <yaar@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Need a short description and bug URL (OOPS!) > + ^^^ please fill out the change log appropriately. otherwise, LGTM

Yaar Schnitman

Comment 6 2010-02-03 16:58:58 PST

Created attachment 48080 [details] Patch

WebKit Review Bot

Comment 7 2010-02-03 17:01:20 PST

Attachment 48080 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/tests/TransparencyWinTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:38: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2010-02-04 01:16:44 PST

Comment on attachment 48080 [details] Patch Clearing flags on attachment: 48080 Committed r54333: <http://trac.webkit.org/changeset/54333>

WebKit Commit Bot

Comment 9 2010-02-04 01:16:53 PST

All reviewed patches have been landed. Closing bug.

Yury Semikhatsky

Comment 10 2010-02-04 02:10:36 PST

(In reply to comment #9) > All reviewed patches have been landed. Closing bug. I reverted the change since it didn't compile on Chromium Win bot: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/1862

Yaar Schnitman

Comment 11 2010-02-04 15:40:11 PST

Created attachment 48178 [details] Patch

WebKit Review Bot

Comment 12 2010-02-04 15:45:05 PST

Attachment 48178 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/tests/TransparencyWinTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/TransparencyWinTest.cpp:38: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:33: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/UniscribeHelperTest.cpp:36: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 6 If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 13 2010-02-04 23:18:16 PST

Comment on attachment 48178 [details] Patch Clearing flags on attachment: 48178 Committed r54410: <http://trac.webkit.org/changeset/54410>

WebKit Commit Bot

Comment 14 2010-02-04 23:18:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Other

OS OS X 10.5

Product WebKit

Component New Bugs

Assignee

Yaar Schnitman

Reported

2010-02-02 18:33 PST

Modified

2010-02-04 23:18 PST History

CC List

4 users Show

URL

Keywords

Depends on

Blocks