Bug 34509 - Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
Summary: Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Yaar Schnitman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 18:33 PST by Yaar Schnitman
Modified: 2010-02-04 23:18 PST (History)
4 users (show)

See Also:


Attachments
Patch (34.57 KB, patch)
2010-02-02 18:34 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff
Patch 2 (34.57 KB, patch)
2010-02-02 18:38 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff
Patch (34.65 KB, patch)
2010-02-03 16:58 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff
Patch (34.71 KB, patch)
2010-02-04 15:40 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2010-02-02 18:33:50 PST
Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
Comment 1 Yaar Schnitman 2010-02-02 18:34:26 PST
Created attachment 47985 [details]
Patch
Comment 2 Yaar Schnitman 2010-02-02 18:38:09 PST
Created attachment 47986 [details]
Patch 2
Comment 3 WebKit Review Bot 2010-02-02 18:39:24 PST
Attachment 47985 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/TransparencyWinTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:38:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2010-02-02 18:39:56 PST
Attachment 47986 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/TransparencyWinTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:38:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Fisher (:fishd, Google) 2010-02-02 20:59:50 PST
Comment on attachment 47986 [details]
Patch 2

> +2010-02-02  Yaar Schnitman  <yaar@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Need a short description and bug URL (OOPS!)
> +

^^^ please fill out the change log appropriately.

otherwise, LGTM
Comment 6 Yaar Schnitman 2010-02-03 16:58:58 PST
Created attachment 48080 [details]
Patch
Comment 7 WebKit Review Bot 2010-02-03 17:01:20 PST
Attachment 48080 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/TransparencyWinTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:38:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2010-02-04 01:16:44 PST
Comment on attachment 48080 [details]
Patch

Clearing flags on attachment: 48080

Committed r54333: <http://trac.webkit.org/changeset/54333>
Comment 9 WebKit Commit Bot 2010-02-04 01:16:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Yury Semikhatsky 2010-02-04 02:10:36 PST
(In reply to comment #9)
> All reviewed patches have been landed.  Closing bug.

I reverted the change since it didn't compile on Chromium Win bot: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/1862
Comment 11 Yaar Schnitman 2010-02-04 15:40:11 PST
Created attachment 48178 [details]
Patch
Comment 12 WebKit Review Bot 2010-02-04 15:45:05 PST
Attachment 48178 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/tests/TransparencyWinTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/TransparencyWinTest.cpp:38:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/UniscribeHelperTest.cpp:36:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 6


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 WebKit Commit Bot 2010-02-04 23:18:16 PST
Comment on attachment 48178 [details]
Patch

Clearing flags on attachment: 48178

Committed r54410: <http://trac.webkit.org/changeset/54410>
Comment 14 WebKit Commit Bot 2010-02-04 23:18:25 PST
All reviewed patches have been landed.  Closing bug.