Bug 34506 - LayoutTests/storage/database-lock-after-reload.html needs to be refactored and made less flaky
Summary: LayoutTests/storage/database-lock-after-reload.html needs to be refactored an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 17:44 PST by Dumitru Daniliuc
Modified: 2010-03-03 17:21 PST (History)
1 user (show)

See Also:

Attachments
patch (5.20 KB, patch)
2010-03-02 18:25 PST, Dumitru Daniliuc 		dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-02-02 17:44:14 PST 
database-lock-after-reload.html has a few problems:

1. Uses the same 'errorFunction' as a statement error callback and transaction error callback. This is not OK, because the two error callbacks have different signatures.
2. Uses RANDOMBLOB which is disallowed by the authorizer. The fact that the test still passes sometimes shows how irrelevant/flaky some operations are.
3. It tries to insert a big enough BLOB in the database, to keep the database thread busy while the main thread navigates to a different page. A 0.5MB BLOB can hardly be considered big enough for this.
4. Some trailing whitespaces.
Comment 1 Dumitru Daniliuc 2010-03-02 18:25:06 PST 
Created attachment 49873 [details]
patch

The flakiness of this test should be completely removed by the fix to bug 35624.
Comment 2 Dimitri Glazkov (Google) 2010-03-03 13:08:16 PST 
Comment on attachment 49873 [details]
patch

ok.
Comment 3 Dumitru Daniliuc 2010-03-03 17:21:44 PST 
Landed as r55490.