Bug 34504 - Crash in CollectorBitmap::get at nbcolympics.com
Summary: Crash in CollectorBitmap::get at nbcolympics.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 15:44 PST by Oliver Hunt
Modified: 2010-02-02 17:17 PST (History)
0 users

See Also:


Attachments
Patch (12.75 KB, patch)
2010-02-02 15:52 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-02-02 15:44:44 PST
Crash in CollectorBitmap::get at nbcolympics.com
Comment 1 Oliver Hunt 2010-02-02 15:52:46 PST
Created attachment 47980 [details]
Patch
Comment 2 Geoffrey Garen 2010-02-02 15:57:05 PST
Comment on attachment 47980 [details]
Patch

r=me

Might be worth adding a comment that explains that m_offset does not include anonymous slots, and the true property offset requires adding the anonymous slot count.
Comment 3 Darin Adler 2010-02-02 15:57:38 PST
Comment on attachment 47980 [details]
Patch

> +        the effected cases by incorporating the anonymous slot count. It

effected -> affected

> +        also removes the duplicate copy of anonymous slot count fro the

fro -> from
Comment 4 Oliver Hunt 2010-02-02 17:17:44 PST
Committed r54265: <http://trac.webkit.org/changeset/54265>